Staging
v0.5.1
v0.5.1
Revision c352e6c7446c894b13643f538db312092b351789 authored by Miss Islington (bot) on 04 February 2020, 22:06:42 UTC, committed by GitHub on 04 February 2020, 22:06:42 UTC
When called on a closed object, readinto() segfaults on account
of a write to a freed buffer:
==220553== Process terminating with default action of signal 11 (SIGSEGV): dumping core
==220553== Access not within mapped region at address 0x2A
==220553== at 0x48408A0: memmove (vg_replace_strmem.c:1272)
==220553== by 0x58DB0C: _buffered_readinto_generic (bufferedio.c:972)
==220553== by 0x58DCBA: _io__Buffered_readinto_impl (bufferedio.c:1053)
==220553== by 0x58DCBA: _io__Buffered_readinto (bufferedio.c.h:253)
Reproducer:
reader = open ("/dev/zero", "rb")
_void = reader.read (42)
reader.close ()
reader.readinto (bytearray (42)) GH-GH-GH- BANG!
The problem exists since 2012 when commit dc469454ec added code
to free the read buffer on close().
Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com>
(cherry picked from commit cb1c0746f277052e45a60d6c436a765e34722821)
Co-authored-by: Philipp Gesang <phg@phi-gamma.net>
Co-authored-by: Philipp Gesang <phg@phi-gamma.net>
1 parent 51332c4
| File | Mode | Size |
|---|---|---|
| Python.asdl | -rw-r--r-- | 5.0 KB |
| acceler.c | -rw-r--r-- | 3.3 KB |
| asdl.py | -rw-r--r-- | 12.6 KB |
| asdl_c.py | -rw-r--r-- | 43.7 KB |
| bitset.c | -rw-r--r-- | 1.0 KB |
| firstsets.c | -rw-r--r-- | 2.8 KB |
| grammar.c | -rw-r--r-- | 7.4 KB |
| grammar1.c | -rw-r--r-- | 1.3 KB |
| listnode.c | -rw-r--r-- | 1.2 KB |
| metagrammar.c | -rw-r--r-- | 2.4 KB |
| myreadline.c | -rw-r--r-- | 10.8 KB |
| node.c | -rw-r--r-- | 4.4 KB |
| parser.c | -rw-r--r-- | 11.6 KB |
| parser.h | -rw-r--r-- | 1.0 KB |
| parsetok.c | -rw-r--r-- | 10.5 KB |
| parsetok_pgen.c | -rw-r--r-- | 35 bytes |
| pgen.c | -rw-r--r-- | 17.9 KB |
| pgenmain.c | -rw-r--r-- | 4.0 KB |
| printgrammar.c | -rw-r--r-- | 2.9 KB |
| tokenizer.c | -rw-r--r-- | 54.8 KB |
| tokenizer.h | -rw-r--r-- | 3.8 KB |
| tokenizer_pgen.c | -rw-r--r-- | 36 bytes |
Computing file changes ...
