Staging
v0.8.1
v0.8.1
Revision 7863c612f402268b5978683f44adad3a7a867613 authored by Jakub Narebski on 14 February 2008, 08:22:30 UTC, committed by Junio C Hamano on 12 March 2008, 16:43:08 UTC
URLs generated by href(..., -replay=>1) (which includes 'next page' links and alternate view links) didn't set project info correctly when current page URL is in pathinfo form. This resulted in broken links such like: http://www.example.com/w/ARRAY(0x85a5318)?a=shortlog;pg=1 if the 'pathinfo' feature was used, or http://www.example.com/w/?a=shortlog;pg=1 if it wasn't, instead of correct: http://www.example.com/w/project.git?a=shortlog;pg=1 This was caused by the fact that href() always replays params in the arrayref form, were they multivalued or singlevalued, and the code dealing with 'pathinfo' feature couldn't deal with $params{'project'} being arrayref. Setting $params{'project'} is moved before replaying params; this ensures that 'project' parameter is processed correctly. Noticed-by: Peter Oberndorfer <kumbayo84@arcor.de> Noticed-by: Wincent Colaiuta <win@wincent.com> Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent ea14e6c
File | Mode | Size |
---|---|---|
hstrerror.c | -rw-r--r-- | 513 bytes |
inet_ntop.c | -rw-r--r-- | 4.9 KB |
inet_pton.c | -rw-r--r-- | 6.9 KB |
memmem.c | -rw-r--r-- | 668 bytes |
mkdtemp.c | -rw-r--r-- | 152 bytes |
mmap.c | -rw-r--r-- | 747 bytes |
pread.c | -rw-r--r-- | 433 bytes |
setenv.c | -rw-r--r-- | 786 bytes |
strcasestr.c | -rw-r--r-- | 431 bytes |
strlcpy.c | -rw-r--r-- | 247 bytes |
strtoumax.c | -rw-r--r-- | 217 bytes |
unsetenv.c | -rw-r--r-- | 558 bytes |
Computing file changes ...