Staging
v0.8.1
Revision 190433d8150bf719fa0ba972dbacf2214942f54e authored by Miss Islington (bot) on 12 February 2020, 02:47:20 UTC, committed by GitHub on 12 February 2020, 02:47:20 UTC

gcc -Wcast-qual turns up a number of instances of casting away constness of pointers. Some of these can be safely modified, by either:

Adding the const to the type cast, as in:

-    return _PyUnicode_FromUCS1((unsigned char*)s, size);
+    return _PyUnicode_FromUCS1((const unsigned char*)s, size);

or, Removing the cast entirely, because it's not necessary (but probably was at one time), as in:

-    PyDTrace_FUNCTION_ENTRY((char *)filename, (char *)funcname, lineno);
+    PyDTrace_FUNCTION_ENTRY(filename, funcname, lineno);

These changes will not change code, but they will make it much easier to check for errors in consts
(cherry picked from commit e6be9b59a911626d6597fe148c32f0342bd2bd24)

Co-authored-by: Andy Lester <andy@petdance.com>
1 parent 0f0d2e4
History
File Mode Size
windows-release
ci.yml -rw-r--r-- 3.2 KB
docs-steps.yml -rw-r--r-- 1.3 KB
macos-steps.yml -rw-r--r-- 771 bytes
posix-deps-apt.sh -rwxr-xr-x 580 bytes
posix-steps.yml -rw-r--r-- 2.5 KB
pr.yml -rw-r--r-- 3.2 KB
prebuild-checks.yml -rw-r--r-- 1.2 KB
windows-layout-steps.yml -rw-r--r-- 1.5 KB
windows-release.yml -rw-r--r-- 3.9 KB
windows-steps.yml -rw-r--r-- 1.5 KB

back to top