Staging
v0.5.1
https://github.com/python/cpython
Revision f5b1abbb3b0083381925dcd5898ae6d019224826 authored by Jason R. Coombs on 08 October 2019, 02:00:02 UTC, committed by Benjamin Peterson on 08 October 2019, 02:00:01 UTC
Backporting this change, I observe a couple of things:

1. The _encode_request call is no longer meaningful because the request construction will implicitly encode the request using the default encoding when the format string is used (request = '%s %s %s'...). In order to keep the code as consistent as possible, I decided to include the call as a pass-through. I'd be just as happy to remove it entirely, but I'll leave that up to the reviewer to decide. It's okay that this functionality is disabled on Python 2 because this functionality was mainly around bpo-36274, which was mainly a concern with the transition to Python 3.
2. Because _encode_request is no longer meaningful, neither is the test for it, so I've removed that test. Therefore, the meaningful part of this test is that for bpo-38216, adding a (underscore-protected) hook to customize/disable validation.

(cherry picked from commit 7774d7831e8809795c64ce27f7df52674581d298)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
1 parent e7e58fe
History
Tip revision: f5b1abbb3b0083381925dcd5898ae6d019224826 authored by Jason R. Coombs on 08 October 2019, 02:00:02 UTC
[2.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16476)
Tip revision: f5b1abb
File Mode Size
NEWS.d
TextMate
Vim
ACKS -rw-r--r-- 23.0 KB
BeOS-NOTES -rw-r--r-- 1.4 KB
BeOS-setup.py -rw-r--r-- 23.1 KB
HISTORY -rw-r--r-- 669.3 KB
Porting -rw-r--r-- 1.9 KB
README -rw-r--r-- 2.3 KB
README.AIX -rw-r--r-- 5.0 KB
README.Emacs -rw-r--r-- 1.0 KB
README.OpenBSD -rw-r--r-- 1.5 KB
README.coverity -rw-r--r-- 845 bytes
README.klocwork -rw-r--r-- 1.2 KB
README.valgrind -rw-r--r-- 4.3 KB
RFD -rw-r--r-- 3.9 KB
SpecialBuilds.txt -rw-r--r-- 10.7 KB
cheatsheet -rw-r--r-- 103.6 KB
developers.txt -rw-r--r-- 12.0 KB
gdbinit -rw-r--r-- 4.7 KB
indent.pro -rw-r--r-- 557 bytes
maintainers.rst -rw-r--r-- 8.0 KB
pymemcompat.h -rw-r--r-- 3.1 KB
python-config.in -rw-r--r-- 1.6 KB
python-wing3.wpr -rw-r--r-- 537 bytes
python-wing4.wpr -rw-r--r-- 698 bytes
python.man -rw-r--r-- 14.2 KB
python.pc.in -rw-r--r-- 253 bytes
setuid-prog.c -rw-r--r-- 5.6 KB
valgrind-python.supp -rw-r--r-- 7.3 KB
vgrindefs -rw-r--r-- 505 bytes

README

back to top