Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision f5b1abbb3b0083381925dcd5898ae6d019224826 authored by Jason R. Coombs on 08 October 2019, 02:00:02 UTC, committed by Benjamin Peterson on 08 October 2019, 02:00:01 UTC 
[2.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16476)
 
Backporting this change, I observe a couple of things:

1. The _encode_request call is no longer meaningful because the request construction will implicitly encode the request using the default encoding when the format string is used (request = '%s %s %s'...). In order to keep the code as consistent as possible, I decided to include the call as a pass-through. I'd be just as happy to remove it entirely, but I'll leave that up to the reviewer to decide. It's okay that this functionality is disabled on Python 2 because this functionality was mainly around bpo-36274, which was mainly a concern with the transition to Python 3.
2. Because _encode_request is no longer meaningful, neither is the test for it, so I've removed that test. Therefore, the meaningful part of this test is that for bpo-38216, adding a (underscore-protected) hook to customize/disable validation.

(cherry picked from commit 7774d7831e8809795c64ce27f7df52674581d298)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
1 parent e7e58fe
History
Tip revision: f5b1abbb3b0083381925dcd5898ae6d019224826 authored by Jason R. Coombs on 08 October 2019, 02:00:02 UTC
[2.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation and encoding behavior (GH-16476)
Tip revision: f5b1abb
File Mode Size
appveyor.yml -rw-r--r-- 1.0 KB
back to top