| f2d0df7 | Shawn Bohrer | 15 April 2008, 03:14:09 UTC | git clean: Don't automatically remove directories when run within subdirectory When git clean is run from a subdirectory it should follow the normal policy and only remove directories if they are passed in as a pathspec, or -d is specified. The fix is to send len which could be shorter than ent->len because we have stripped the trailing '/' that read_directory adds. Additionaly match_one() was modified to allow a name[] that is not NUL terminated. This allows us to check if the name matched the pathspec exactly instead of recursively. Signed-off-by: Shawn Bohrer <shawn.bohrer@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 15 April 2008, 06:14:58 UTC |
| f669ac0 | Mark Levedahl | 15 April 2008, 02:48:06 UTC | git-submodule - possibly use branch name to describe a module This changes the search logic for describing a submodule from: - annotated tag - any tag - tag on a subsequent commit - commit id to - annotated tag - any tag - tag on a subsequent commit - local or remote branch - commit id The change is describing with respect to a branch before falling back to the commit id. By itself, git-submodule will maintain submodules as headless checkouts without ever making a local branch. In general, such heads can always be described relative to the remote branch regardless of existence of tags, and so provides a better fallback summary than just the commit id. This requires inserting an extra describe step as --contains is incompatible with --all, but the latter can be used with --always to fall back to a commit ID. Also, --contains implies --tags, so the latter is not needed. Signed-off-by: Mark Levedahl <mlevedahl@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 15 April 2008, 06:14:08 UTC |
| 02604e2 | Junio C Hamano | 13 April 2008, 01:57:08 UTC | t7401: squelch garbage output The script had an unconditional output done outside of test_expect_* construct, which leaked out and contaminated the output without -v. Squelch it. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 13 April 2008, 01:57:08 UTC |
| 51836e9 | Junio C Hamano | 13 April 2008, 01:34:39 UTC | Documentation/git-submodule: typofix Signed-off-by: Junio C Hamano <gitster@pobox.com> | 13 April 2008, 01:34:39 UTC |
| 60e3aba | Daniel Barkalow | 12 April 2008, 19:32:00 UTC | Fix config key miscount in url.*.insteadOf Also tighten test to require it to be correct. Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 22:41:24 UTC |
| d6d96f8 | Junio C Hamano | 12 April 2008, 22:41:19 UTC | Merge branch 'maint-1.5.4' into maint * maint-1.5.4: Docs gitk: Explicitly mention the files that gitk uses (~/.gitk) Document -w option to shortlog bisect: report bad rev better | 12 April 2008, 22:41:19 UTC |
| e809507 | Clifford Caoile | 12 April 2008, 09:50:20 UTC | Docs gitk: Explicitly mention the files that gitk uses (~/.gitk) gitk creates and uses ~/.gitk Signed-off-by: Clifford Caoile <piyo@users.sourceforge.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 22:39:07 UTC |
| 55ef8a4 | Junio C Hamano | 12 April 2008, 22:38:20 UTC | Document -w option to shortlog Noticed by Fredrik Noring. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 22:38:20 UTC |
| a179a30 | Christian Couder | 12 April 2008, 09:17:36 UTC | bisect: report bad rev better The previous one overwrote the variable used to report the bad input when the input is actually bad, and we did not give a useful enough information. This corrects it. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 22:16:13 UTC |
| eed8183 | Junio C Hamano | 12 April 2008, 06:55:55 UTC | Merge branch 'maint-1.5.4' into maint * maint-1.5.4: bisect: fix bad rev checking in "git bisect good" revision.c: make --date-order overriddable Fix section about backdating tags in the git-tag docs Document option --only of git commit Documentation/git-request-pull: Fixed a typo ("send" -> "end") | 12 April 2008, 06:55:55 UTC |
| e338907 | Christian Couder | 12 April 2008, 05:53:59 UTC | bisect: fix bad rev checking in "git bisect good" It seems that "git bisect good" and "git bisect skip" have never properly checked arguments that have been passed to them. As soon as one of them can be parsed as a SHA1, no error or warning would be given. This is because 'git rev-parse --revs-only --no-flags "$@"' always "exit 0" and outputs all the SHA1 it can found from parsing "$@". This patch fix this by using, for each "bisect good" argument, the same logic as for the "bisect bad" argument. While at it, this patch teaches "bisect bad" to give a meaningfull error message when it is passed more than one argument. Note that if "git bisect good" or "git bisect skip" is given some proper revs and then something that is not a proper rev, then the first proper revs will still have been marked as "good" or "skip". Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 06:54:45 UTC |
| a710522 | Michele Ballabio | 10 April 2008, 20:06:52 UTC | revision.c: make --date-order overriddable Jan Engelhardt noticed that while --topo-order can be overridden by a subsequent --date-order, the reverse was not possible. That's because setup_revisions() failed to set revs->lifo properly. Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 06:01:33 UTC |
| a68972c | Ping Yin | 10 April 2008, 14:45:29 UTC | git-submodule: Avoid 'fatal: cannot describe' message When "git submodule status" command tries to show the name of the submodule HEAD revision more descriptively, but the submodule repository lacked a suitable tag to do so, it leaked "fatal: cannot describe" message to the UI. Squelch it by using '--always'. Signed-off-by: Ping Yin <pkufranky@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 00:35:39 UTC |
| b6309ac | Pedro Melo | 10 April 2008, 16:05:21 UTC | Force the medium pretty format on calls to git log If a user has customized format.pretty in config, git-svn rebase fails with: Unable to determine upstream SVN information from working tree history because the command expects to read the commit log in the default format. This fixes the command to explicitly ask for the format it wants to read from. Signed-off-by: Pedro Melo <melo@simplicidade.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 00:35:35 UTC |
| 055b661 | Björn Steinbrink | 11 April 2008, 20:52:07 UTC | Fix section about backdating tags in the git-tag docs The tagger is equal to the committer, not the author, so GIT_COMMITTER_DATE is the right environment variable to use, not GIT_AUTHOR_DATE. Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 12 April 2008, 00:34:05 UTC |
| d4ba07c | Johannes Sixt | 10 April 2008, 11:33:09 UTC | Document option --only of git commit Its documentation was removed by 6c96753 (Documentation/git-commit: rewrite to make it more end-user friendly, 2006-12-08), even though it is referenced from a few places, including builtin-commit.c (as part of the commentary in the commit message template). Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 11 April 2008, 19:54:15 UTC |
| ca593f7 | Dirk Suesserott | 09 April 2008, 20:20:10 UTC | Documentation/git-request-pull: Fixed a typo ("send" -> "end") Signed-off-by: Dirk Suesserott <newsletter@dirk.my1.cc> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 11 April 2008, 19:25:30 UTC |
| f59774a | Jeff King | 10 April 2008, 00:03:49 UTC | git-fetch: fix status output when not storing tracking ref There was code in update_local_ref for handling this case, but it never actually got called. It assumed that storing in FETCH_HEAD meant a blank peer_ref name, but we actually have a NULL peer_ref in this case, so we never even made it to the update_local_ref function. On top of that, the display formatting was different from all of the other cases, probably owing to the fact that nobody had ever actually seen the output. This patch harmonizes the output with the other cases and moves the detection of this case into store_updated_refs, where we can actually trigger it. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 April 2008, 07:30:44 UTC |
| 179c94b | Junio C Hamano | 10 April 2008, 07:29:33 UTC | Merge branch 'maint-1.5.4' into maint * maint-1.5.4: core-tutorial.txt: Fix showing the current behaviour. git-archive: ignore prefix when checking file attribute Fix documentation syntax of optional arguments in short options. | 10 April 2008, 07:29:33 UTC |
| abea85d | Carlos Rica | 10 April 2008, 00:08:23 UTC | core-tutorial.txt: Fix showing the current behaviour. The --root option from "git diff-tree" won't do nothing when is given to commands like git-whatchanged or git-log, because those always print the initial commit by default. This fixes the tutorial explaining the function of the log.showroot configuration variable. Signed-off-by: Carlos Rica <jasampler@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 April 2008, 07:20:41 UTC |
| ac7fa27 | René Scharfe | 09 April 2008, 21:14:43 UTC | git-archive: ignore prefix when checking file attribute Ulrik Sverdrup noticed that git-archive doesn't correctly apply the attribute export-subst when the option --prefix is given, too. When it checked if a file has the attribute turned on, git-archive would try to look up the full path -- including the prefix -- in .gitattributes. That's wrong, as the prefix doesn't need to have any relation to any existing directories, tracked or not. This patch makes git-archive ignore the prefix when looking up if value of the attribute export-subst for a file. Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 April 2008, 07:20:38 UTC |
| 3f36cbb | Carlos Rica | 09 April 2008, 11:07:14 UTC | Fix documentation syntax of optional arguments in short options. When an argument for an option is optional, like in -n from git-tag, puting a space between the option and the argument is interpreted as a missing argument for the option plus an isolated argument. Documentation now reflects the need to write the parameter following the option -n, as in "git tag -nARG", for instance. Signed-off-by: Carlos Rica <jasampler@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 10 April 2008, 07:20:31 UTC |
| 1d2375d | Junio C Hamano | 08 April 2008, 04:57:43 UTC | GIT 1.5.5 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 08 April 2008, 04:57:43 UTC |
| fae09a8 | Junio C Hamano | 08 April 2008, 04:52:23 UTC | Merge git://git.kernel.org/pub/scm/gitk/gitk * git://git.kernel.org/pub/scm/gitk/gitk: gitk: Fix changing colors through Edit->Preferences | 08 April 2008, 04:52:23 UTC |
| f61cc48 | Eric Wong | 07 April 2008, 07:08:03 UTC | git-svn: fix following renamed paths when tracking a single path When using git-svn to follow only a single (empty) path per svn-remote (i.e. not using --stdlayout), following the history of a renamed path was broken in c586879cdfa4f8181a14e953a9152a4639eef333. This reverts the regression for the single (emtpy) path per svn-remote case. To avoid breaking the tests in a committed revision, this is an addendum to a patch originally submitted by Santhosh Kumar Mani <santhoshmani@gmail.com>: > git-svn: add test for renamed directory fetch > > This test tries to fetch a directory which had renames in the > history from a SVN repository. [ew: unneccesary dependency on the starting an HTTP server removed from Santhosh's original test.] Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 07:16:08 UTC |
| a1c0dca | Junio C Hamano | 07 April 2008, 03:04:29 UTC | Merge branch 'jc/maint-apply-match-beginning' * jc/maint-apply-match-beginning: Fix "git apply" to correctly enforce "match at the beginning" | 07 April 2008, 03:04:29 UTC |
| aba201c | Pascal Obry | 06 April 2008, 16:56:08 UTC | Add prefix oriented completions for diff and format-patch commands. Signed-off-by: Pascal Obry <pascal@obry.net> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 03:03:09 UTC |
| f2b3e3c | Christian Couder | 06 April 2008, 17:08:50 UTC | test suite: remove useless TERM cruft in "t7005-editor.sh" In commit 15387e3 (Test suite: reset TERM to its previous value after testing., 2007-10-26), I added a workaround to reset TERM to its previous value before the "test_done" at the end of "t7005-editor.sh" because otherwise "test_done" would have printed the test result with a bad TERM env variable (this resulted in output with no color on konsole). But since commit c2116a1 (test-lib: fix TERM to dumb for test repeatability, 2008-03-06), colored output is printed in a subshell with TERM reset to its original value so the earlier workaround is not needed anymore. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 03:02:43 UTC |
| d9e3b70 | Pascal Obry | 06 April 2008, 17:32:24 UTC | Add interactive option in rebase command completion list. Signed-off-by: Pascal Obry <pascal@obry.net> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 03:01:17 UTC |
| ee5a317 | Junio C Hamano | 07 April 2008, 02:21:45 UTC | Fix "git apply" to correctly enforce "match at the beginning" An earlier commit 4be6096 (apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches, 2006-09-17) made match_beginning and match_end computed incorrectly. If a hunk inserts at the beginning, old position recorded at the hunk is line 0, and if a hunk changes at the beginning, it is line 1. The new test added to t4104 exposes that the old code did not insist on matching at the beginning for a patch to add a line to an empty file. An even older 65aadb9 (apply: force matching at the beginning., 2006-05-24) was equally wrong in that it tried to take hints from the number of leading context lines, to decide if the hunk must match at the beginning, but we can just look at the line number in the hunk to decide. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 02:21:45 UTC |
| 9de328f | Peter Eriksen | 06 April 2008, 20:51:49 UTC | Add description of OFS_DELTA to the pack format description Signed-off-by: Peter Eriksen <s022018@student.dtu.dk> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 07 April 2008, 00:22:46 UTC |
| 80dd7b4 | Gerrit Pape | 26 March 2008, 18:45:26 UTC | gitk: Fix changing colors through Edit->Preferences With tcl/tk8.5 the lset command seems to behave differently. When changing the background color through Edit->Preferences, the changes are applied, but new dialogs, such as View->New view... barf with Error: unknown color name "{#ffffff}" Additionally when closing gitk, and starting it up again, a bad value has been saved to ~/.gitk, preventing gitk from running properly; it fails with Error in startup script: unknown color name "{#ffffff}" ... This commit fixes the problem by changing the color dialogs to pass the empty string {} as the list index to choosecolor. This causes the lset and lindex commands used by choosecolor to use and set the whole variable (bgcolor, fgcolor or selectbgcolor) rather than treating them as a 1-element list. Tested with tcl/tk8.4 and 8.5. Dmitry Potapov reported this problem through http://bugs.debian.org/472615 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Paul Mackerras <paulus@samba.org> | 06 April 2008, 03:07:27 UTC |
| ba1333f | Peter Eriksen | 05 April 2008, 19:46:49 UTC | git-pack-objects.txt: Make wording slightly less ambiguous It is a bit confusing on first read, that "The packed archive format (.pack) is designed to be unpackable..." Signed-off-by: Peter Eriksen <s022018@student.dtu.dk> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 05 April 2008, 23:51:16 UTC |
| f53423b | Kevin Ballard | 05 April 2008, 18:28:53 UTC | git-fetch: Don't trigger a bus error when given the refspec "tag" When git-fetch encounters the refspec "tag" it assumes that the next argument will be a tag name. If there is no next argument, it should die gracefully instead of erroring. Signed-off-by: Kevin Ballard <kevin@sb.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 05 April 2008, 23:31:45 UTC |
| 4ed4a34 | Jakub Narebski | 05 April 2008, 20:13:24 UTC | Revert "gitweb: Add 'status_str' to parse_difftree_raw_line output" This reverts commit 6aa6f92fda47cc4ee5f599895e8a5a327fb6f9ab. It caused is_deleted() subroutine to output warnings when dealing with old, legacy gitweb blobdiff URLs without either 'hb' or 'hpb' parameters. This fixes http://bugs.debian.org/469083 Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 05 April 2008, 23:30:49 UTC |
| 77ad7a4 | Junio C Hamano | 05 April 2008, 05:38:32 UTC | Merge git://repo.or.cz/git-gui * git://repo.or.cz/git-gui: git-gui: use +/- instead of ]/[ to show more/less context in diff git-gui: Update french translation git-gui: Switch keybindings for [ and ] to bracketleft and bracketright | 05 April 2008, 05:38:32 UTC |
| 729ffa5 | Michele Ballabio | 04 April 2008, 21:04:42 UTC | git-gui: use +/- instead of ]/[ to show more/less context in diff On some systems, brackets cannot be used as event details (they don't have a keysym), so use +/- instead (both on keyboard and keypad) and add ctrl-= as a synonym of ctrl-+ for convenience. [sp: Had to change accelerator to show only "$M1T-="; the original version included "$M1T-+ $M1T-=" but this is not drawn at all on Mac OS X.] Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 05 April 2008, 04:03:19 UTC |
| ccb3b53 | Christian Couder | 05 April 2008, 02:20:23 UTC | git-gui: Update french translation Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 05 April 2008, 03:53:50 UTC |
| 54906ad | Shawn O. Pearce | 03 April 2008, 22:06:29 UTC | git-gui: Switch keybindings for [ and ] to bracketleft and bracketright Thanks to Michele Ballabio for the quick fix. This resolves the error introduced by c91ee2bd61. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 04 April 2008, 01:38:12 UTC |
| 6c41b80 | Junio C Hamano | 02 April 2008, 17:42:14 UTC | GIT 1.5.5-rc3 The rate of fixes that trickle in has slowed and we are definitely getting there. Hopefully one final round and we will have the final 1.5.5 soon. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 18:13:25 UTC |
| eedb9d9 | Junio C Hamano | 02 April 2008, 18:13:23 UTC | Merge branch 'js/filter-branch' * js/filter-branch: filter-branch: Fix renaming a directory in the tree-filter filter-branch: Test renaming directories in a tree-filter | 02 April 2008, 18:13:23 UTC |
| cfc4ba3 | Teemu Likonen | 02 April 2008, 17:06:46 UTC | Describe the bug in handling filenames with funny characters in 'git add -i' The interactive mode does not work with files whose names contain characters that need C-quoting. `core.quotepath` configuration can be used to work this limitation around to some degree, but backslash, double-quote and control characters will still have problems. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 17:36:31 UTC |
| 7ae512b | Junio C Hamano | 02 April 2008, 17:29:10 UTC | Merge git://repo.or.cz/git-gui * git://repo.or.cz/git-gui: git-gui 0.10 git-gui: Add shortcut keys for Show More/Less Context | 02 April 2008, 17:29:10 UTC |
| 5fbd0a4 | Junio C Hamano | 02 April 2008, 07:23:19 UTC | Merge branch 'bc/mktag' * bc/mktag: mktag.c: tweak validation of tagger field and adjust test script mktag.c: improve verification of tagger field and tests | 02 April 2008, 07:23:19 UTC |
| e0efa03 | Junio C Hamano | 02 April 2008, 07:22:20 UTC | Merge branch 'pb/cvsserver' * pb/cvsserver: git-cvsserver: handle change type T | 02 April 2008, 07:22:20 UTC |
| 22e885e | Junio C Hamano | 02 April 2008, 07:22:15 UTC | Merge branch 'dd/cvsserver' * dd/cvsserver: cvsserver: Use the user part of the email in log and annotate results cvsserver: Add test for update -p cvsserver: Implement update -p (print to stdout) cvsserver: Add a few tests for 'status' command cvsserver: Do not include status output for subdirectories if -l is passed cvsserver: Only print the file part of the filename in status header cvsserver: Respond to the 'editors' and 'watchers' commands | 02 April 2008, 07:22:15 UTC |
| 860bbd5 | Junio C Hamano | 02 April 2008, 07:22:06 UTC | Merge branch 'je/cvsserver' * je/cvsserver: Allow git-cvsserver database table name prefix to be specified. | 02 April 2008, 07:22:06 UTC |
| 64fb19b | Johannes Sixt | 02 April 2008, 06:52:37 UTC | t7004-tag: Skip more tests if gpg is not available. This test was already careful enough to skip signed tag tests if gpg is not available, but it must also skip all verify tests, even those that are about non-signed tags, because they also invoke gpg. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 07:13:43 UTC |
| 69fe5ef | Johannes Sixt | 02 April 2008, 06:49:59 UTC | verify-tag: Clean up the temporary file if gpg cannot be started. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 07:08:30 UTC |
| 4637e47 | Christian Couder | 02 April 2008, 03:47:41 UTC | help: Add a missing OPT_END(). Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 06:40:06 UTC |
| e85dc0a | Junio C Hamano | 01 April 2008, 04:33:09 UTC | Accept git aliases outside a git repository af05d67 (Always set *nongit_ok in setup_git_directory_gently(), 2008-03-25) had a change from the patch originally submitted that resulted in disabling aliases outside a git repository. It turns out that some people used "alias.fubar = diff --color-words" in $HOME/.gitconfig to use non-index diff (or any command that do not need git repository) outside git repositories, and this change broke them, so this resurrects the support for such usage. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 02 April 2008, 06:40:02 UTC |
| 3d654be | Shawn O. Pearce | 02 April 2008, 06:17:11 UTC | git-gui 0.10 Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 02 April 2008, 06:17:11 UTC |
| c91ee2b | Jonathan del Strother | 01 April 2008, 10:54:03 UTC | git-gui: Add shortcut keys for Show More/Less Context Bound to Ctrl/Cmd + left & right square brackets, depending on your platform. [sp: Added missing binds for . to allow shortcuts to work when not focused in the commit message area.] Signed-off-by: Jonathan del Strother <jon.delStrother@bestbefore.tv> Signed-off-by: Shawn O. Pearce <spearce@spearce.org> | 02 April 2008, 05:33:32 UTC |
| ba26ab9 | Brandon Casey | 31 March 2008, 23:25:23 UTC | mktag.c: tweak validation of tagger field and adjust test script Update the verify_tag() function to remove an unnecessary test, and add additional check for angle brackets in the name and email field, and spaces in the email field. The timestamp and timezone sections are made more straight forward by using strspn(). Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 01 April 2008, 05:43:34 UTC |
| 6a589fd | veillette@yahoo.ca | 31 March 2008, 07:14:15 UTC | filter-branch: Fix renaming a directory in the tree-filter Commit d89c1df (filter-branch: don't use xargs -0, 2008-03-12) replaced a 'ls-files | xargs rm' pipeline by 'git clean'. 'git clean' however does not recurse and remove directories by default. Now, consider a tree-filter that renames a directory. 1. For the first commit everything works as expected 2. Then filter-branch checks out the files for the next commit. This leaves the new directory behind because there is no real "branch switching" involved that would notice that the directory can be removed. 3. Then filter-branch invokes 'git clean' to remove exactly those left-overs. But here it does not remove the directory. 4. The next tree-filter does not work as expected because there already exists a directory with the new name. Just add -d to 'git clean', so that empty directories are removed. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 08:09:50 UTC |
| 9035628 | Johannes Sixt | 31 March 2008, 07:14:14 UTC | filter-branch: Test renaming directories in a tree-filter This test currently fails. If b is a directory then 'mv a b' is not a plain "rename", but really a "move", so we must also test that the directory does not exist with the old name in the directory with the new name. There's also some cleanup in the corresponding "rename file" test to avoid spurious shell syntax errors and "ambigous ref" error from 'git show' (but these should show up only if the test would fail anyway). Plus we also test for the non-existence of the old file. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> | 31 March 2008, 08:03:05 UTC |
| e0aaf78 | Brandon Casey | 27 March 2008, 16:16:04 UTC | mktag.c: improve verification of tagger field and tests Since nearly its birth, git's tags have included a "tagger" field which describes the name of tagger, email of tagger, and date and time of tagging. But, this field was only loosely tested by git-mktag. Provide some thorough testing for this field and also ensure that the tag header is separated from the tag body by an empty line to reduce the convenience of creating a flawed tag. Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:54:09 UTC |
| f58dbf2 | Junio C Hamano | 31 March 2008, 00:30:08 UTC | diff-files: careful when inspecting work tree items This fixes the same breakage in diff-files. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:22:09 UTC |
| 948dd34 | Junio C Hamano | 31 March 2008, 00:29:48 UTC | diff-index: careful when inspecting work tree items Earlier, if you changed a staged path into a directory in the work tree, we happily ran lstat(2) on it and found that it exists, and declared that the user changed it to a gitlink. This is wrong for two reasons: (1) It may be a directory, but it may not be a submodule, and in the latter case, the change we need to report is "the blob at the path has disappeared". We need to check with resolve_gitlink_ref() to be consistent with what "git add" and "git update-index --add" does. (2) lstat(2) may have succeeded only because a leading component of the path was turned into a symbolic link that points at something that exists in the work tree. In such a case, the path itself does not exist anymore, as far as the index is concerned. This fixes these breakages in diff-index that the previous patch has exposed. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:22:09 UTC |
| 6301f30 | Junio C Hamano | 31 March 2008, 00:28:05 UTC | Add corner case tests for diff-index and diff-files diff-index and diff-files can get confused in corner cases when an indexed blob turns into something else in the work tree. This patch adds tests to expose such breakages. The test is classified under t2XXX series instead of t4XXX series, because the ultimate objective is to fix "add -u" (and "commit -a" that shares the same issue). Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:22:09 UTC |
| 6aeeffd | Josh Elsasser | 27 March 2008, 21:02:14 UTC | Allow git-cvsserver database table name prefix to be specified. Adds a gitcvs.dbtablenameprefix config variable, the contents of which are prepended to any database tables names used by git-cvsserver. The same substutions as gitcvs.dbname and gitcvs.dbuser are supported, and any non-alphabetic characters are replaced with underscores. A typo found in contrib/completion/git-completion.bash is also fixed. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:21:35 UTC |
| c20711d | Bryan Donlan | 28 March 2008, 06:19:46 UTC | Silence cpio's "N blocks" output when cloning locally Pass --quiet to cpio in git-clone to hide the (confusing) "0 blocks" message. For compatibility with operating systems which might not support GNUisms, the presence of --quiet is probed for by grepping cpio's --help output. Signed-off-by: Bryan Donlan <bdonlan@fushizen.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:21:06 UTC |
| 67dac28 | Eric Wong | 29 March 2008, 23:37:17 UTC | git-svn: remove redundant slashes from show-ignore Jonathan Scott Duff wrote: > Recently I tried "git svn showignore" on my parrot repository and it > failed. I tracked it down to the prop_walk() sub. When it recurses, > $path has an extra / on the beginning (i.e., when it recurses, it > tries to get the props for "//apps" instead of "/apps"). I *think* > this is because $path is used in the recursive call rather than $p > (which seems to contain a properly transformed $path). Anyway, I've > attached a patch that works for me and I think is generally the right > thing. Patch-submitted-by: Jonathan Scott Duff Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 31 March 2008, 05:03:05 UTC |
| f3e5ae4 | Marius Storm-Olsen | 28 March 2008, 14:40:40 UTC | git-p4: Handle Windows EOLs properly after removal of p4 submit template handling. git-p4s handling of Windows style EOL was broken after the removal of the p4 submit template handling in commit f2a6059. Fix that, and make getP4OpenedType() more robust. Signed-off-by: Marius Storm-Olsen <marius@trolltech.com> Signed-off-by: Simon Hausmann <simon@lst.de> | 28 March 2008, 15:27:39 UTC |
| 9027efe | Paolo Bonzini | 16 March 2008, 19:00:21 UTC | git-cvsserver: handle change type T git-cvsserver does not support changes of type T (file type change, e.g. symlink->real file). This patch treats them the same as changes of type M. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 March 2008, 06:51:33 UTC |
| 803d515 | Junio C Hamano | 28 March 2008, 03:43:51 UTC | GIT 1.5.5-rc2 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 March 2008, 03:43:51 UTC |
| f8dd64f | Junio C Hamano | 28 March 2008, 03:36:35 UTC | GIT 1.5.4.5 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 28 March 2008, 03:36:35 UTC |
| c1bc306 | Damien Diederen | 27 March 2008, 22:18:35 UTC | cvsserver: Use the user part of the email in log and annotate results Generate the CVS author names by taking the first eight characters of the user part of the email address. The resulting names are more likely to make sense (or at least reduce ambiguities) in "corporate" environments. Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| 6e8937a | Damien Diederen | 27 March 2008, 22:18:23 UTC | cvsserver: Add test for update -p Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| e78f69a | Damien Diederen | 27 March 2008, 22:18:12 UTC | cvsserver: Implement update -p (print to stdout) Cvs update -p -r <rev> <path> is the documented way to retrieve a specific revision of a file (similar to git show <rev>:<path>). Without this patch, the -p flag is ignored and status output is produced, causing clients to interpret it as the contents of the file. TkCVS uses update -p as a basis for implementing its various "View" and "Diff" commands. Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| dded801 | Damien Diederen | 27 March 2008, 22:18:02 UTC | cvsserver: Add a few tests for 'status' command Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| 852b921 | Damien Diederen | 27 March 2008, 22:17:53 UTC | cvsserver: Do not include status output for subdirectories if -l is passed This effectively implements the -l switch by pruning the entries whose filenames contain a path separator. It was previously ignored. Without this, TkCVS includes strange "ghost" entries in its directory listings. Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| 23b7180 | Damien Diederen | 27 March 2008, 22:17:42 UTC | cvsserver: Only print the file part of the filename in status header The "File:" header of CVS status output only includes the basename of the file, even when generating a recursive listing; do the same. Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| 38bcd31 | Damien Diederen | 27 March 2008, 22:17:26 UTC | cvsserver: Respond to the 'editors' and 'watchers' commands These commands list users editing and watching locked files. This trivial implementation always returns an empty response, since git-cvsserver does not implement file locking. Without this, TkCVS hangs at startup, waiting forever for a response. Signed-off-by: Damien Diederen <dash@foobox.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 23:05:27 UTC |
| fe308f5 | Junio C Hamano | 25 March 2008, 06:20:51 UTC | builtin-prune: protect objects listed on the command line Finally, this resurrects the documented behaviour to protect other objects listed on the command line from getting pruned. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 22:39:57 UTC |
| 629de47 | Michele Ballabio | 23 March 2008, 20:50:29 UTC | builtin-prune.c: use parse_options() Using the OPT_DATE() introduced earlier, this updates builtin-prune to use parse_options(). Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:55:15 UTC |
| 0c62705 | Michele Ballabio | 23 March 2008, 21:34:34 UTC | Add tests for git-prune It seems that git prune changed behaviour with respect to revisions added from command line, probably when it became a builtin. Currently, it prints a short usage and exits: instead, it should take those revisions into account and not prune them. So add a couple of test to point this out. We'll be fixing this by switching to parse_options(), so add tests to detect bogus command line parameters as well, to keep ourselves from introducing regressions. Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:55:15 UTC |
| 1f4a711 | Michele Ballabio | 24 March 2008, 14:02:21 UTC | parse-options.c: introduce OPT_DATE There are quite a few places that will need to call approxidate(), when they'll adopt the parse-options system, so this patch adds the function parse_opt_approxidate_cb(), used by OPT_DATE. Signed-off-by: Michele Ballabio <barra_cuda@katamail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:55:15 UTC |
| 1768905 | Junio C Hamano | 27 March 2008, 20:37:29 UTC | Update draft release notes for 1.5.5 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:37:29 UTC |
| 319a36a | Junio C Hamano | 27 March 2008, 20:35:18 UTC | Merge branch 'maint' * maint: Update draft release notes for 1.5.4.5 Documentation: clarify use of .git{ignore,attributes} versus .git/info/* t/t3800-mktag.sh: use test_must_fail rather than '!' Conflicts: t/t3800-mktag.sh | 27 March 2008, 20:35:18 UTC |
| 24362a5 | Junio C Hamano | 27 March 2008, 20:14:20 UTC | Update draft release notes for 1.5.4.5 Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:14:20 UTC |
| b88605f | Junio C Hamano | 27 March 2008, 20:03:56 UTC | Merge branch 'jc/maint-fetch-regression-1.5.4' into maint * jc/maint-fetch-regression-1.5.4: git-fetch test: test tracking fetch results, not just FETCH_HEAD Fix branches file configuration Tighten refspec processing | 27 March 2008, 20:03:56 UTC |
| 90b2290 | Jeff King | 27 March 2008, 05:31:00 UTC | Documentation: clarify use of .git{ignore,attributes} versus .git/info/* gitignore patterns can be read from three different files, while gitattributes can come from two files. Let's provide some hints to the user about the differences and how they are typically used. Suggested by Toby Corkindale, but gratuitously reworded by Jeff King. Signed-off-by: Toby Corkindale <toby.corkindale@rea-group.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 20:03:51 UTC |
| 8ee002f | Junio C Hamano | 25 March 2008, 06:07:08 UTC | test_must_fail: 129 is a valid error code from usage() When a git command is run under test_must_fail to make sure that the argument parser catches bogus command line, it exits with 129. We need to catch it as a valid "graceful error exit". Signed-off-by: Junio C Hamano <gitster@pobox.com> | 27 March 2008, 19:13:39 UTC |
| 5b67b8e | Gerrit Pape | 26 March 2008, 18:05:17 UTC | imap-send: properly error out if imap.host is not set in config If no imap host is specified in the git config, git imap-send used to try to lookup a null pointer through gethostbyname(), causing a segfault. Since setting the imap.host variable is mandatory, imap-send now properly fails with an explanatory error message. The problem has been reported by picca through http://bugs.debian.org/472632 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 23:15:02 UTC |
| 40ae887 | Frank Lichtenheld | 26 March 2008, 17:34:20 UTC | t9600-cvsimport.sh: set HOME before checking for cvsps availability This actually sounds like a bug in cvsps, which requires an existing home directory when asked for the usage through -h $ HOME=/nonexistent cvsps -h Cannot create the cvsps directory '.cvsps': No such file or directory This made t9600 think that cvsps is not available if HOME did not exist, causing the tests to be skipped $ HOME=/nonexistent sh t9600-cvsimport.sh * skipping cvsimport tests, cvsps not found * passed all 0 test(s) Now t9600 sets HOME to the current working directory before checking for the availability of the cvsps program. This issue has been discovered by Marco Rodrigues, and fixed by Frank Lichtenheld through http://bugs.debian.org/471969 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 23:14:52 UTC |
| af05d67 | SZEDER Gábor | 25 March 2008, 21:06:26 UTC | Always set *nongit_ok in setup_git_directory_gently() setup_git_directory_gently() only modified the value of its *nongit_ok argument if we were not in a git repository. Now it will always set it to 0 when we are inside a repository. Also remove now unnecessary initializations in the callers of this function. Signed-off-by: SZEDER Gábor <szeder@ira.uka.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 22:41:35 UTC |
| 525d461 | Brandon Casey | 26 March 2008, 00:20:52 UTC | t/t3800-mktag.sh: use test_must_fail rather than '!' Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 21:26:52 UTC |
| 660b9c3 | Junio C Hamano | 26 March 2008, 08:49:41 UTC | Merge branch 'jc/maint-fetch-regression-1.5.4' * jc/maint-fetch-regression-1.5.4: git-fetch test: test tracking fetch results, not just FETCH_HEAD Fix branches file configuration Tighten refspec processing Fix the wrong output of `git-show v1.3.0~155^2~4` in documentation. | 26 March 2008, 08:49:41 UTC |
| a466637 | Junio C Hamano | 26 March 2008, 08:17:07 UTC | git-fetch test: test tracking fetch results, not just FETCH_HEAD We really should have done this long time ago. Existing t5515 test was written for the specific purpose of catching regression to the contents of generated FETCH_HEAD file, but it also is a good place to make sure various fetch configurations do fetch what they intend to fetch (and nothing else). Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 08:29:54 UTC |
| 472fa4c | Daniel Barkalow | 25 March 2008, 23:35:28 UTC | Fix branches file configuration Fetched remote branch from .git/branches/foo should fetch into refs/heads/foo. Also when partial URL is given, the fetched head should always be remote HEAD, and the result should not be stored anywhere. Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 07:50:51 UTC |
| c091b3d | Daniel Barkalow | 18 March 2008, 02:05:23 UTC | Tighten refspec processing This changes the pattern matching code to not store the required final / before the *, and then to require each side to be a valid ref (or empty). In particular, any refspec that looks like it should be a pattern but doesn't quite meet the requirements will be found to be invalid as a fallback non-pattern. This was cherry picked from commit ef00d15 (Tighten refspec processing, 2008-03-17), and two fix-up commits 46220ca (remote.c: Fix overtight refspec validation, 2008-03-20) and 7d19da4 (refspec: allow colon-less wildcard "refs/category/*", 2008-03-25) squashed in. Signed-off-by: Daniel Barkalow <barkalow@iabervon.org> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 07:10:55 UTC |
| 71a5099 | Guanqun Lu | 24 March 2008, 07:27:28 UTC | Fix the wrong output of `git-show v1.3.0~155^2~4` in documentation. Texts between ~ and ~ will be subscripted during the asciidoc translation. Signed-off-by: Guanqun Lu <Guanqun.Lu@Gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> (cherry picked from commit 0c829391cfcdc57172765322575804a7ad5f3116) | 26 March 2008, 07:09:17 UTC |
| 7d19da4 | Junio C Hamano | 26 March 2008, 04:15:52 UTC | refspec: allow colon-less wildcard "refs/category/*" "git push --tags elsewhere" is implemented in terms of wildcarded refspec "refs/tags/*" these days, and the user wants to push the tags under the same name to the other branch. This resurrects the support for it. Signed-off-by: Junio C Hamano <gitster@pobox.com> | 26 March 2008, 04:55:38 UTC |
| 5cc8f37 | Johannes Schindelin | 24 March 2008, 15:14:52 UTC | init: show "Reinit" message even in an (existing) empty repository Earlier, git-init tested for a valid HEAD ref, but if the repository was empty, there was none. Instead, test for the existence of the file $GIT_DIR/HEAD. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 25 March 2008, 07:34:05 UTC |
| 76ce946 | Julian Phillips | 24 March 2008, 03:06:20 UTC | Documentation/git-checkout: Update summary to reflect current abilities For a while now, git-checkout has been more powerful than the man-page summary would suggest (the main text does describe the new features), so update the summary to hopefully better reflect the current functionality. Also update the glossary description of the word checkout. Signed-off-by: Julian Phillips <julian@quantumfyre.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 25 March 2008, 07:00:07 UTC |
| 995e8df | Dirk Süsserott | 24 March 2008, 19:43:08 UTC | Documentation: git-tag '-m'/'-F' implies '-a' | 25 March 2008, 05:14:35 UTC |
| ec31b0c | Johannes Sixt | 18 March 2008, 20:52:00 UTC | builtin-remote: Fix missing newline at end of listing of pushed branches Without this the output of 'git remote show' does not end with a new-line: bash> git remote show repo * remote repo URL: repo.or.cz:/srv/git/kdbg.git Tracked remote branches maint master mob Local branch pushed with 'git push' +master:masterbash> Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at> Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 24 March 2008, 00:11:33 UTC |
| 0c82939 | Guanqun Lu | 24 March 2008, 07:27:28 UTC | Fix the wrong output of `git-show v1.3.0~155^2~4` in documentation. Texts between ~ and ~ will be subscripted during the asciidoc translation. Signed-off-by: Guanqun Lu <Guanqun.Lu@Gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 23 March 2008, 19:02:11 UTC |
| 313da4f | Johannes Schindelin | 23 March 2008, 11:35:37 UTC | RelNotes: mention checkout/branch's --track option, too checkout and branch recently learnt to track local branches when branch.autosetupmerge = always, but they _also_ learnt to do that when asked explicitely with the option "--track". Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com> | 23 March 2008, 17:16:33 UTC |
