Staging
v0.5.1
https://github.com/python/cpython
Revision db95802bdfac4d13db3e2a391ec7b9e2f8d92dbe authored by Miss Islington (bot) on 22 November 2020, 17:33:09 UTC, committed by GitHub on 22 November 2020, 17:33:09 UTC
The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28)

Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent 9ae1742
History
Tip revision: db95802bdfac4d13db3e2a391ec7b9e2f8d92dbe authored by Miss Islington (bot) on 22 November 2020, 17:33:09 UTC
bpo-40791: Make compare_digest more constant-time. (GH-23438)
Tip revision: db95802
File Mode Size
c-api
data
distributing
distutils
extending
faq
howto
includes
install
installing
library
reference
tools
tutorial
using
whatsnew
Makefile -rw-r--r-- 7.4 KB
README.rst -rw-r--r-- 4.5 KB
about.rst -rw-r--r-- 1.5 KB
bugs.rst -rw-r--r-- 4.3 KB
conf.py -rw-r--r-- 6.4 KB
contents.rst -rw-r--r-- 538 bytes
copyright.rst -rw-r--r-- 451 bytes
glossary.rst -rw-r--r-- 52.0 KB
license.rst -rw-r--r-- 43.4 KB
make.bat -rw-r--r-- 5.5 KB

README.rst

back to top