Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision d8948c5e09c4a2a818f6f6cfaf8064f2c2138fa5 authored by Miss Islington (bot) on 29 May 2018, 22:37:06 UTC, committed by GitHub on 29 May 2018, 22:37:06 UTC
Currently, asyncio.wait_for(fut), upon reaching the timeout deadline,
cancels the future and returns immediately. This is problematic for
when *fut* is a Task, because it will be left running for an arbitrary
amount of time. This behavior is iself surprising and may lead to
related bugs such as the one described in bpo-33638:
condition = asyncio.Condition()
async with condition:
await asyncio.wait_for(condition.wait(), timeout=0.5)
Currently, instead of raising a TimeoutError, the above code will fail
with `RuntimeError: cannot wait on un-acquired lock`, because
`__aexit__` is reached _before_ `condition.wait()` finishes its
cancellation and re-acquires the condition lock.
To resolve this, make `wait_for` await for the task cancellation.
The tradeoff here is that the `timeout` promise may be broken if the
task decides to handle its cancellation in a slow way. This represents
a behavior change and should probably not be back-patched to 3.6 and
earlier.
(cherry picked from commit e2b340ab4196e1beb902327f503574b5d7369185)
Co-authored-by: Elvis Pranskevichus <elvis@magic.io> 1 parent 0364342
Tip revision: d8948c5e09c4a2a818f6f6cfaf8064f2c2138fa5 authored by Miss Islington (bot) on 29 May 2018, 22:37:06 UTC
bpo-32751: Wait for task cancellation in asyncio.wait_for() (GH-7216)
bpo-32751: Wait for task cancellation in asyncio.wait_for() (GH-7216)
Tip revision: d8948c5
| File | Mode | Size |
|---|---|---|
| NEWS.d | ||
| ACKS | -rw-r--r-- | 26.0 KB |
| HISTORY | -rw-r--r-- | 1.3 MB |
| Porting | -rw-r--r-- | 63 bytes |
| README | -rw-r--r-- | 1.4 KB |
| README.AIX | -rw-r--r-- | 4.7 KB |
| README.coverity | -rw-r--r-- | 845 bytes |
| README.valgrind | -rw-r--r-- | 4.5 KB |
| SpecialBuilds.txt | -rw-r--r-- | 9.7 KB |
| coverity_model.c | -rw-r--r-- | 4.1 KB |
| gdbinit | -rw-r--r-- | 4.7 KB |
| indent.pro | -rw-r--r-- | 557 bytes |
| python-config.in | -rw-r--r-- | 2.0 KB |
| python-config.sh.in | -rw-r--r-- | 2.9 KB |
| python-wing3.wpr | -rw-r--r-- | 555 bytes |
| python-wing4.wpr | -rw-r--r-- | 835 bytes |
| python-wing5.wpr | -rw-r--r-- | 835 bytes |
| python.man | -rw-r--r-- | 13.2 KB |
| python.pc.in | -rw-r--r-- | 293 bytes |
| svnmap.txt | -rw-r--r-- | 4.1 MB |
| valgrind-python.supp | -rw-r--r-- | 8.2 KB |
| vgrindefs | -rw-r--r-- | 500 bytes |
Computing file changes ...
