Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision d8948c5e09c4a2a818f6f6cfaf8064f2c2138fa5 authored by Miss Islington (bot) on 29 May 2018, 22:37:06 UTC, committed by GitHub on 29 May 2018, 22:37:06 UTC
Currently, asyncio.wait_for(fut), upon reaching the timeout deadline, cancels the future and returns immediately. This is problematic for when *fut* is a Task, because it will be left running for an arbitrary amount of time. This behavior is iself surprising and may lead to related bugs such as the one described in bpo-33638: condition = asyncio.Condition() async with condition: await asyncio.wait_for(condition.wait(), timeout=0.5) Currently, instead of raising a TimeoutError, the above code will fail with `RuntimeError: cannot wait on un-acquired lock`, because `__aexit__` is reached _before_ `condition.wait()` finishes its cancellation and re-acquires the condition lock. To resolve this, make `wait_for` await for the task cancellation. The tradeoff here is that the `timeout` promise may be broken if the task decides to handle its cancellation in a slow way. This represents a behavior change and should probably not be back-patched to 3.6 and earlier. (cherry picked from commit e2b340ab4196e1beb902327f503574b5d7369185) Co-authored-by: Elvis Pranskevichus <elvis@magic.io>
1 parent 0364342
Tip revision: d8948c5e09c4a2a818f6f6cfaf8064f2c2138fa5 authored by Miss Islington (bot) on 29 May 2018, 22:37:06 UTC
bpo-32751: Wait for task cancellation in asyncio.wait_for() (GH-7216)
bpo-32751: Wait for task cancellation in asyncio.wait_for() (GH-7216)
Tip revision: d8948c5
File | Mode | Size |
---|---|---|
docs-release.yml | -rw-r--r-- | 1.2 KB |
docs.yml | -rw-r--r-- | 1.0 KB |
linux-buildbot.yml | -rw-r--r-- | 1.7 KB |
linux-coverage.yml | -rw-r--r-- | 2.2 KB |
linux-deps.yml | -rw-r--r-- | 1.1 KB |
linux-pr.yml | -rw-r--r-- | 1.9 KB |
macos-buildbot.yml | -rw-r--r-- | 733 bytes |
macos-pr.yml | -rw-r--r-- | 733 bytes |
windows-buildbot.yml | -rw-r--r-- | 1.1 KB |
windows-pr.yml | -rw-r--r-- | 1.1 KB |
Computing file changes ...