Staging
v0.7.0
https://github.com/torvalds/linux
Revision cc65f1ec192dc54de57483194502e9fa00934c39 authored by H. Peter Anvin on 03 October 2008, 20:00:56 UTC, committed by H. Peter Anvin on 03 October 2008, 20:42:04 UTC
Impact: segfault on build of a 32-bit relocatable kernel

When converting arch/x86/boot/compressed/relocs.c to support unlimited
sections, the computation of sym_strtab in walk_relocs() was done
incorrectly.  This causes a segfault for some people when building the
relocatable 32-bit kernel.

Pointed out by Anonymous <pageexec@freemail.hu>.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
1 parent 95b866d
Raw File
Tip revision: cc65f1ec192dc54de57483194502e9fa00934c39 authored by H. Peter Anvin on 03 October 2008, 20:00:56 UTC
x86 setup: correct segfault in generation of 32-bit reloc kernel
Tip revision: cc65f1e
rtc-ppc.c
/*
 * RTC driver for ppc_md RTC functions
 *
 * © 2007 Red Hat, Inc.
 *
 * Author: David Woodhouse <dwmw2@infradead.org>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 2 as
 * published by the Free Software Foundation.
 */


#include <linux/module.h>
#include <linux/err.h>
#include <linux/rtc.h>
#include <linux/platform_device.h>
#include <asm/machdep.h>

static int ppc_rtc_read_time(struct device *dev, struct rtc_time *tm)
{
	ppc_md.get_rtc_time(tm);
	return 0;
}

static int ppc_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
	return ppc_md.set_rtc_time(tm);
}

static const struct rtc_class_ops ppc_rtc_ops = {
	.set_time = ppc_rtc_set_time,
	.read_time = ppc_rtc_read_time,
};

static struct rtc_device *rtc;
static struct platform_device *ppc_rtc_pdev;

static int __init ppc_rtc_init(void)
{
	if (!ppc_md.get_rtc_time || !ppc_md.set_rtc_time)
		return -ENODEV;

	ppc_rtc_pdev = platform_device_register_simple("ppc-rtc", 0, NULL, 0);
	if (IS_ERR(ppc_rtc_pdev))
		return PTR_ERR(ppc_rtc_pdev);

	rtc = rtc_device_register("ppc_md", &ppc_rtc_pdev->dev,
				  &ppc_rtc_ops, THIS_MODULE);
	if (IS_ERR(rtc)) {
		platform_device_unregister(ppc_rtc_pdev);
		return PTR_ERR(rtc);
	}

	return 0;
}

static void __exit ppc_rtc_exit(void)
{
	rtc_device_unregister(rtc);
	platform_device_unregister(ppc_rtc_pdev);
}

module_init(ppc_rtc_init);
module_exit(ppc_rtc_exit);

MODULE_LICENSE("GPL");
MODULE_AUTHOR("David Woodhouse <dwmw2@infradead.org>");
MODULE_DESCRIPTION("Generic RTC class driver for PowerPC");
back to top