Staging
v0.8.1
https://github.com/python/cpython
Revision c41559021213cfc9dc62a83fc63306b3bdc3e64b authored by MARUYAMA Norihiro on 01 November 2020, 23:51:04 UTC, committed by GitHub on 01 November 2020, 23:51:04 UTC
* bpo-37193: remove the thread which finished process request from threads list

* rename variable t to thread.

* don't remove thread from list if it is daemon.

* use lock to protect self._threads.

* use finally block in case of exception from shutdown_request().

* check "not thread.daemon" before lock to avoid holding the lock if it's unnecessary.

* fix the place of _threads_lock.

* separate code to remove a current thread into a function.

* check ValueError when removing thread.

* fix wrong code which all instance shared same lock.

* Extract thread management into a _Threads class to encapsulate atomic operations and separate concerns.

* Replace multiple references of 'block_on_close' with one, avoiding the possibility that 'block_on_close' could change during the course of processing requests. Now, there's exactly one _threads object with behavior fixed for the duration.

* Add docstrings to private classes.

* Add test to ensure that a ThreadingTCPServer can be closed without serving any requests.

* Use _NoThreads as the default value. Fixes AttributeError when server is closed without serving any requests.

* Add blurb

* Add test capturing failure.

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
1 parent e662c39
History
Tip revision: c41559021213cfc9dc62a83fc63306b3bdc3e64b authored by MARUYAMA Norihiro on 01 November 2020, 23:51:04 UTC
bpo-37193: remove thread objects which finished process its request (GH-13893)
Tip revision: c415590
File Mode Size
c-api
data
distributing
distutils
extending
faq
howto
includes
install
installing
library
reference
tools
tutorial
using
whatsnew
Makefile -rw-r--r-- 8.5 KB
README.rst -rw-r--r-- 4.6 KB
about.rst -rw-r--r-- 1.5 KB
bugs.rst -rw-r--r-- 4.7 KB
conf.py -rw-r--r-- 7.1 KB
contents.rst -rw-r--r-- 538 bytes
copyright.rst -rw-r--r-- 451 bytes
glossary.rst -rw-r--r-- 53.2 KB
license.rst -rw-r--r-- 46.5 KB
make.bat -rw-r--r-- 5.5 KB
requirements.txt -rw-r--r-- 381 bytes
runtime.txt -rw-r--r-- 3 bytes

README.rst

back to top