Staging
v0.5.0
v0.5.0
https://github.com/python/cpython
Revision c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC, committed by GitHub on 21 November 2020, 09:18:41 UTC
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent ed02018
Tip revision: c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: c1bbca5
| File | Mode | Size |
|---|---|---|
| .azure-pipelines | ||
| .github | ||
| Doc | ||
| Grammar | ||
| Include | ||
| Lib | ||
| Mac | ||
| Misc | ||
| Modules | ||
| Objects | ||
| PC | ||
| PCbuild | ||
| Parser | ||
| Programs | ||
| Python | ||
| Tools | ||
| m4 | ||
| .gitattributes | -rw-r--r-- | 1.8 KB |
| .gitignore | -rw-r--r-- | 1.8 KB |
| .travis.yml | -rw-r--r-- | 8.3 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 630 bytes |
| LICENSE | -rw-r--r-- | 13.6 KB |
| Makefile.pre.in | -rw-r--r-- | 68.9 KB |
| README.rst | -rw-r--r-- | 9.9 KB |
| aclocal.m4 | -rw-r--r-- | 13.1 KB |
| config.guess | -rwxr-xr-x | 43.1 KB |
| config.sub | -rwxr-xr-x | 35.4 KB |
| configure | -rwxr-xr-x | 499.6 KB |
| configure.ac | -rw-r--r-- | 168.7 KB |
| install-sh | -rwxr-xr-x | 15.0 KB |
| netlify.toml | -rw-r--r-- | 82 bytes |
| pyconfig.h.in | -rw-r--r-- | 44.4 KB |
| setup.py | -rw-r--r-- | 108.5 KB |
Computing file changes ...
