Skip to main content

Browse the archive

Staging
v0.8.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC, committed by GitHub on 21 November 2020, 09:18:41 UTC 
bpo-40791: Make compare_digest more constant-time. (GH-20444)
 

* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28)

Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent ed02018
History
Tip revision: c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: c1bbca5
File Mode Size
pegen
pgen
Python.asdl -rw-r--r-- 5.2 KB
acceler.c -rw-r--r-- 3.3 KB
asdl.py -rw-r--r-- 12.7 KB
asdl_c.py -rwxr-xr-x 48.8 KB
grammar1.c -rw-r--r-- 1.0 KB
listnode.c -rw-r--r-- 1.7 KB
myreadline.c -rw-r--r-- 11.6 KB
node.c -rw-r--r-- 5.1 KB
parser.c -rw-r--r-- 12.4 KB
parser.h -rw-r--r-- 1.4 KB
parsetok.c -rw-r--r-- 14.0 KB
token.c -rw-r--r-- 4.5 KB
tokenizer.c -rw-r--r-- 56.9 KB
tokenizer.h -rw-r--r-- 3.8 KB
back to top