Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC, committed by GitHub on 21 November 2020, 09:18:41 UTC
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent ed02018
Tip revision: c1bbca5b004b3f74d240ef8a76ff445cc1a27efb authored by Miss Islington (bot) on 21 November 2020, 09:18:41 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: c1bbca5
| File | Mode | Size |
|---|---|---|
| c-api | ||
| data | ||
| distributing | ||
| distutils | ||
| extending | ||
| faq | ||
| howto | ||
| includes | ||
| install | ||
| installing | ||
| library | ||
| reference | ||
| tools | ||
| tutorial | ||
| using | ||
| whatsnew | ||
| Makefile | -rw-r--r-- | 8.5 KB |
| README.rst | -rw-r--r-- | 4.6 KB |
| about.rst | -rw-r--r-- | 1.5 KB |
| bugs.rst | -rw-r--r-- | 4.7 KB |
| conf.py | -rw-r--r-- | 7.1 KB |
| contents.rst | -rw-r--r-- | 538 bytes |
| copyright.rst | -rw-r--r-- | 451 bytes |
| glossary.rst | -rw-r--r-- | 53.2 KB |
| license.rst | -rw-r--r-- | 46.5 KB |
| make.bat | -rw-r--r-- | 5.5 KB |
| requirements.txt | -rw-r--r-- | 381 bytes |
| runtime.txt | -rw-r--r-- | 3 bytes |
Computing file changes ...
