Staging
v0.8.1
https://github.com/python/cpython
Revision b9e5547f5814962964c4a5bd5cd36a2af8fbf974 authored by Miss Islington (bot) on 22 November 2019, 23:36:38 UTC, committed by GitHub on 22 November 2019, 23:36:38 UTC

* fix HTTP Digest handling in request.py

There is a bug triggered when server replies to a request with `WWW-Authenticate: Digest` where `qop="auth,auth-int"` rather than mere `qop="auth"`. Having both `auth` and `auth-int` is legitimate according to the `qop-options` rule in §3.2.1 of [[https://www.ietf.org/rfc/rfc2617.txt|RFC 2617]]:
>      qop-options       = "qop" "=" <"> 1GH-qop-value <">
>      qop-value         = "auth" | "auth-int" | token
> **qop-options**: [...] If present, it is a quoted string **of one or more** tokens indicating the "quality of protection" values supported by the server.  The value `"auth"` indicates authentication; the value `"auth-int"` indicates authentication with integrity protection

This is description confirmed by the definition of the [//n//]`GH-`[//m//]//rule// extended-BNF pattern defined in §2.1 of [[https://www.ietf.org/rfc/rfc2616.txt|RFC 2616]] as 'a comma-separated list of //rule// with at least //n// and at most //m// items'.

When this reply is parsed by `get_authorization`, request.py only tests for identity with `'auth'`, failing to recognize it as one of the supported modes the server announced, and claims that `"qop 'auth,auth-int' is not supported"`.

* 📜🤖 Added by blurb_it.

* bpo-38686 review fix: remember why.

* fix trailing space in Lib/urllib/request.py

Co-Authored-By: Brandt Bucher <brandtbucher@gmail.com>
(cherry picked from commit 14a89c47983f2fb9e7fdf33c769e622eefd3a14a)

Co-authored-by: PypeBros <PypeBros@users.noreply.github.com>
1 parent ca5fafc
History
Tip revision: b9e5547f5814962964c4a5bd5cd36a2af8fbf974 authored by Miss Islington (bot) on 22 November 2019, 23:36:38 UTC
bpo-38686: fix HTTP Digest handling in request.py (GH-17045)
Tip revision: b9e5547
File Mode Size
clinic
Python-ast.c -rw-r--r-- 283.8 KB
README -rw-r--r-- 62 bytes
_warnings.c -rw-r--r-- 37.1 KB
asdl.c -rw-r--r-- 1.4 KB
ast.c -rw-r--r-- 188.1 KB
ast_opt.c -rw-r--r-- 23.4 KB
ast_unparse.c -rw-r--r-- 24.6 KB
bltinmodule.c -rw-r--r-- 82.8 KB
bootstrap_hash.c -rw-r--r-- 17.3 KB
ceval.c -rw-r--r-- 176.3 KB
ceval_gil.h -rw-r--r-- 8.4 KB
codecs.c -rw-r--r-- 44.9 KB
compile.c -rw-r--r-- 170.9 KB
condvar.h -rw-r--r-- 8.4 KB
context.c -rw-r--r-- 29.7 KB
dtoa.c -rw-r--r-- 77.8 KB
dup2.c -rw-r--r-- 759 bytes
dynamic_annotations.c -rw-r--r-- 6.6 KB
dynload_aix.c -rw-r--r-- 5.7 KB
dynload_dl.c -rw-r--r-- 581 bytes
dynload_hpux.c -rw-r--r-- 1.9 KB
dynload_shlib.c -rw-r--r-- 3.4 KB
dynload_stub.c -rw-r--r-- 186 bytes
dynload_win.c -rw-r--r-- 10.0 KB
errors.c -rw-r--r-- 43.4 KB
fileutils.c -rw-r--r-- 52.5 KB
formatter_unicode.c -rw-r--r-- 50.3 KB
frozen.c -rw-r--r-- 1.8 KB
frozenmain.c -rw-r--r-- 3.1 KB
future.c -rw-r--r-- 4.7 KB
getargs.c -rw-r--r-- 85.9 KB
getcompiler.c -rw-r--r-- 538 bytes
getcopyright.c -rw-r--r-- 511 bytes
getopt.c -rw-r--r-- 4.6 KB
getplatform.c -rw-r--r-- 133 bytes
getversion.c -rw-r--r-- 308 bytes
graminit.c -rw-r--r-- 53.2 KB
hamt.c -rw-r--r-- 79.0 KB
import.c -rw-r--r-- 66.0 KB
importdl.c -rw-r--r-- 7.3 KB
importdl.h -rw-r--r-- 487 bytes
importlib.h -rw-r--r-- 94.2 KB
importlib_external.h -rw-r--r-- 145.2 KB
importlib_zipimport.h -rw-r--r-- 57.8 KB
initconfig.c -rw-r--r-- 74.8 KB
makeopcodetargets.py -rwxr-xr-x 1.6 KB
marshal.c -rw-r--r-- 48.5 KB
modsupport.c -rw-r--r-- 17.6 KB
mysnprintf.c -rw-r--r-- 3.3 KB
mystrtoul.c -rw-r--r-- 8.1 KB
opcode_targets.h -rw-r--r-- 6.3 KB
pathconfig.c -rw-r--r-- 20.1 KB
peephole.c -rw-r--r-- 19.0 KB
preconfig.c -rw-r--r-- 24.4 KB
pyarena.c -rw-r--r-- 5.5 KB
pyctype.c -rw-r--r-- 7.7 KB
pyfpe.c -rw-r--r-- 345 bytes
pyhash.c -rw-r--r-- 13.2 KB
pylifecycle.c -rw-r--r-- 65.4 KB
pymath.c -rw-r--r-- 1.6 KB
pystate.c -rw-r--r-- 49.7 KB
pystrcmp.c -rw-r--r-- 613 bytes
pystrhex.c -rw-r--r-- 4.2 KB
pystrtod.c -rw-r--r-- 40.1 KB
pythonrun.c -rw-r--r-- 47.6 KB
pytime.c -rw-r--r-- 26.6 KB
strdup.c -rw-r--r-- 251 bytes
structmember.c -rw-r--r-- 8.6 KB
symtable.c -rw-r--r-- 63.5 KB
sysmodule.c -rw-r--r-- 91.7 KB
thread.c -rw-r--r-- 5.3 KB
thread_nt.h -rw-r--r-- 11.8 KB
thread_pthread.h -rw-r--r-- 23.7 KB
traceback.c -rw-r--r-- 24.7 KB
wordcode_helpers.h -rw-r--r-- 1.2 KB

README

back to top