Staging
v0.5.1
https://github.com/python/cpython
Revision a67bd53d3f80ac9c518b5426aa35459bd373b2b3 authored by Elvis Pranskevichus on 03 October 2018, 15:49:00 UTC, committed by Miss Islington (bot) on 03 October 2018, 15:49:00 UTC


The C implementation of asyncio.Task currently fails to perform the
cancellation cleanup correctly in the following scenario.

    async def task1():
        async def task2():
            await task3     # task3 is never cancelled

        asyncio.current_task().cancel()
        await asyncio.create_task(task2())

The actuall error is a hardcoded call to `future_cancel()` instead of
calling the `cancel()` method of a future-like object.

Thanks to Vladimir Matveev for noticing the code discrepancy and to
Yury Selivanov for coming up with a pathological scenario..
(cherry picked from commit 548ce9dedd2e90945970671d441436a6a91608ab)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>


https://bugs.python.org/issue34872
1 parent 063755c
History
Tip revision: a67bd53d3f80ac9c518b5426aa35459bd373b2b3 authored by Elvis Pranskevichus on 03 October 2018, 15:49:00 UTC
[3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9691)
Tip revision: a67bd53
File Mode Size
.azure-pipelines
.github
Doc
Grammar
Include
Lib
Mac
Misc
Modules
Objects
PC
PCbuild
Parser
Programs
Python
Tools
m4
.gitattributes -rw-r--r-- 1.5 KB
.gitignore -rw-r--r-- 1.5 KB
.travis.yml -rw-r--r-- 6.0 KB
CODE_OF_CONDUCT.rst -rw-r--r-- 631 bytes
LICENSE -rw-r--r-- 12.5 KB
Makefile.pre.in -rw-r--r-- 61.1 KB
README.rst -rw-r--r-- 9.9 KB
aclocal.m4 -rw-r--r-- 10.7 KB
config.guess -rwxr-xr-x 43.1 KB
config.sub -rwxr-xr-x 35.4 KB
configure -rwxr-xr-x 483.4 KB
configure.ac -rw-r--r-- 161.5 KB
install-sh -rwxr-xr-x 7.0 KB
pyconfig.h.in -rw-r--r-- 42.1 KB
setup.py -rw-r--r-- 99.5 KB

README.rst

back to top