Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision a67bd53d3f80ac9c518b5426aa35459bd373b2b3 authored by Elvis Pranskevichus on 03 October 2018, 15:49:00 UTC, committed by Miss Islington (bot) on 03 October 2018, 15:49:00 UTC 
[3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9691)
 


The C implementation of asyncio.Task currently fails to perform the
cancellation cleanup correctly in the following scenario.

    async def task1():
        async def task2():
            await task3     # task3 is never cancelled

        asyncio.current_task().cancel()
        await asyncio.create_task(task2())

The actuall error is a hardcoded call to `future_cancel()` instead of
calling the `cancel()` method of a future-like object.

Thanks to Vladimir Matveev for noticing the code discrepancy and to
Yury Selivanov for coming up with a pathological scenario..
(cherry picked from commit 548ce9dedd2e90945970671d441436a6a91608ab)

Co-authored-by: Elvis Pranskevichus <elvis@magic.io>


https://bugs.python.org/issue34872
1 parent 063755c
History
Tip revision: a67bd53d3f80ac9c518b5426aa35459bd373b2b3 authored by Elvis Pranskevichus on 03 October 2018, 15:49:00 UTC
[3.7] bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) (GH-9691)
Tip revision: a67bd53
File Mode Size
README -rw-r--r-- 67 bytes
_freeze_importlib.c -rw-r--r-- 4.7 KB
_testembed.c -rw-r--r-- 19.0 KB
python.c -rw-r--r-- 266 bytes

README

back to top