Staging
v0.6.0
Revision a0783cd0c810504427777e8aae20d5f4f8b652a0 authored by Corinna Vinschen on 19 November 2019, 09:09:39 UTC, committed by David S. Miller on 20 November 2019, 00:41:11 UTC
During performance testing, I found that one of my r8169 NICs suffered
a major performance loss, a 8168c model.

Running netperf's TCP_STREAM test didn't return the expected
throughput of > 900 Mb/s, but rather only about 22 Mb/s.  Strange
enough, running the TCP_MAERTS and UDP_STREAM tests all returned with
throughput > 900 Mb/s, as did TCP_STREAM with the other r8169 NICs I can
test (either one of 8169s, 8168e, 8168f).

Bisecting turned up commit 93681cd7d94f83903cb3f0f95433d10c28a7e9a5,
"r8169: enable HW csum and TSO" as the culprit.

I added my 8168c version, RTL_GIGA_MAC_VER_22, to the code
special-casing the 8168evl as per the patch below.  This fixed the
performance problem for me.

Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c9d55b6
History
File Mode Size
Makefile -rw-r--r-- 418 bytes
generic_mpih-add1.c -rw-r--r-- 1.3 KB
generic_mpih-lshift.c -rw-r--r-- 1.5 KB
generic_mpih-mul1.c -rw-r--r-- 1.3 KB
generic_mpih-mul2.c -rw-r--r-- 1.3 KB
generic_mpih-mul3.c -rw-r--r-- 1.3 KB
generic_mpih-rshift.c -rw-r--r-- 1.5 KB
generic_mpih-sub1.c -rw-r--r-- 1.3 KB
longlong.h -rw-r--r-- 39.0 KB
mpi-bit.c -rw-r--r-- 1.5 KB
mpi-cmp.c -rw-r--r-- 1.6 KB
mpi-inline.h -rw-r--r-- 2.6 KB
mpi-internal.h -rw-r--r-- 5.3 KB
mpi-pow.c -rw-r--r-- 7.7 KB
mpicoder.c -rw-r--r-- 9.0 KB
mpih-cmp.c -rw-r--r-- 1.3 KB
mpih-div.c -rw-r--r-- 5.2 KB
mpih-mul.c -rw-r--r-- 13.6 KB
mpiutil.c -rw-r--r-- 2.7 KB

back to top