Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/torvalds/linux
02 December 2023, 22:23:51 UTC
Revision a0783cd0c810504427777e8aae20d5f4f8b652a0 authored by Corinna Vinschen on 19 November 2019, 09:09:39 UTC, committed by David S. Miller on 20 November 2019, 00:41:11 UTC 
r8169: disable TSO on a single version of RTL8168c to fix performance
 
During performance testing, I found that one of my r8169 NICs suffered
a major performance loss, a 8168c model.

Running netperf's TCP_STREAM test didn't return the expected
throughput of > 900 Mb/s, but rather only about 22 Mb/s.  Strange
enough, running the TCP_MAERTS and UDP_STREAM tests all returned with
throughput > 900 Mb/s, as did TCP_STREAM with the other r8169 NICs I can
test (either one of 8169s, 8168e, 8168f).

Bisecting turned up commit 93681cd7d94f83903cb3f0f95433d10c28a7e9a5,
"r8169: enable HW csum and TSO" as the culprit.

I added my 8168c version, RTL_GIGA_MAC_VER_22, to the code
special-casing the 8168evl as per the patch below.  This fixed the
performance problem for me.

Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO")
Signed-off-by: Corinna Vinschen <vinschen@redhat.com>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c9d55b6
History
Tip revision: a0783cd0c810504427777e8aae20d5f4f8b652a0 authored by Corinna Vinschen on 19 November 2019, 09:09:39 UTC
r8169: disable TSO on a single version of RTL8168c to fix performance
Tip revision: a0783cd
File Mode Size
Kconfig -rw-r--r-- 7.3 KB
Kconfig.debug -rw-r--r-- 2.7 KB
Makefile -rw-r--r-- 516 bytes
rcu.h -rw-r--r-- 15.9 KB
rcu_segcblist.c -rw-r--r-- 16.7 KB
rcu_segcblist.h -rw-r--r-- 4.3 KB
rcuperf.c -rw-r--r-- 17.6 KB
rcutorture.c -rw-r--r-- 73.4 KB
srcutiny.c -rw-r--r-- 5.9 KB
srcutree.c -rw-r--r-- 44.2 KB
sync.c -rw-r--r-- 6.2 KB
tiny.c -rw-r--r-- 4.1 KB
tree.c -rw-r--r-- 113.5 KB
tree.h -rw-r--r-- 19.2 KB
tree_exp.h -rw-r--r-- 24.6 KB
tree_plugin.h -rw-r--r-- 80.6 KB
tree_stall.h -rw-r--r-- 21.0 KB
update.c -rw-r--r-- 28.8 KB
back to top