Staging
v0.8.1
v0.8.1
https://github.com/torvalds/linux
Revision 98d8256739f2c6c636fa2da359f5949c739ae839 authored by Thomas Gleixner on 23 May 2007, 20:58:18 UTC, committed by Linus Torvalds on 24 May 2007, 03:14:15 UTC
The NOHZ patch contains a check for softirqs pending when a CPU goes idle. The BUG is unrelated to NOHZ, it just was made visible by the NOHZ patch. The BUG showed up mainly on P4 / hyperthreading enabled machines which lead the investigations into the wrong direction in the first place. The real cause is in cond_resched_softirq(): cond_resched_softirq() is enabling softirqs without invoking the softirq daemon when softirqs are pending. This leads to the warning message in the NOHZ idle code: t1 runs softirq disabled code on CPU#0 interrupt happens, softirq is raised, but deferred (softirqs disabled) t1 calls cond_resched_softirq() enables softirqs via _local_bh_enable() calls schedule() t2 runs t1 is migrated to CPU#1 t2 is done and invokes idle() NOHZ detects the pending softirq Fix: change _local_bh_enable() to local_bh_enable() so the softirq daemon is invoked. Thanks to Anant Nitya for debugging this with great patience ! Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@elte.hu> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 40acc09
Tip revision: 98d8256739f2c6c636fa2da359f5949c739ae839 authored by Thomas Gleixner on 23 May 2007, 20:58:18 UTC
Prevent going idle with softirq pending
Prevent going idle with softirq pending
Tip revision: 98d8256
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 13.3 KB |
Makefile | -rw-r--r-- | 1.7 KB |
ablkcipher.c | -rw-r--r-- | 2.4 KB |
aes.c | -rw-r--r-- | 11.6 KB |
algapi.c | -rw-r--r-- | 12.6 KB |
anubis.c | -rw-r--r-- | 27.8 KB |
api.c | -rw-r--r-- | 9.4 KB |
arc4.c | -rw-r--r-- | 2.0 KB |
blkcipher.c | -rw-r--r-- | 12.0 KB |
blowfish.c | -rw-r--r-- | 17.4 KB |
camellia.c | -rw-r--r-- | 58.0 KB |
cast5.c | -rw-r--r-- | 34.1 KB |
cast6.c | -rw-r--r-- | 21.5 KB |
cbc.c | -rw-r--r-- | 8.7 KB |
cipher.c | -rw-r--r-- | 2.6 KB |
compress.c | -rw-r--r-- | 1.4 KB |
crc32c.c | -rw-r--r-- | 2.6 KB |
cryptd.c | -rw-r--r-- | 9.2 KB |
crypto_null.c | -rw-r--r-- | 3.3 KB |
cryptomgr.c | -rw-r--r-- | 3.6 KB |
deflate.c | -rw-r--r-- | 5.4 KB |
des.c | -rw-r--r-- | 35.4 KB |
digest.c | -rw-r--r-- | 3.7 KB |
ecb.c | -rw-r--r-- | 4.9 KB |
fcrypt.c | -rw-r--r-- | 18.0 KB |
gf128mul.c | -rw-r--r-- | 12.9 KB |
hash.c | -rw-r--r-- | 1.6 KB |
hmac.c | -rw-r--r-- | 6.7 KB |
internal.h | -rw-r--r-- | 4.2 KB |
khazad.c | -rw-r--r-- | 51.8 KB |
lrw.c | -rw-r--r-- | 7.6 KB |
md4.c | -rw-r--r-- | 6.2 KB |
md5.c | -rw-r--r-- | 7.2 KB |
michael_mic.c | -rw-r--r-- | 3.5 KB |
pcbc.c | -rw-r--r-- | 8.8 KB |
proc.c | -rw-r--r-- | 3.0 KB |
scatterwalk.c | -rw-r--r-- | 2.5 KB |
scatterwalk.h | -rw-r--r-- | 2.2 KB |
serpent.c | -rw-r--r-- | 19.7 KB |
sha1.c | -rw-r--r-- | 3.2 KB |
sha256.c | -rw-r--r-- | 11.1 KB |
sha512.c | -rw-r--r-- | 10.3 KB |
tcrypt.c | -rw-r--r-- | 36.3 KB |
tcrypt.h | -rw-r--r-- | 161.6 KB |
tea.c | -rw-r--r-- | 7.1 KB |
tgr192.c | -rw-r--r-- | 31.1 KB |
twofish.c | -rw-r--r-- | 6.2 KB |
twofish_common.c | -rw-r--r-- | 39.6 KB |
wp512.c | -rw-r--r-- | 60.3 KB |
xcbc.c | -rw-r--r-- | 9.1 KB |
Computing file changes ...