Staging
v0.5.1
https://github.com/python/cpython
Revision 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC, committed by GitHub on 10 June 2020, 20:38:42 UTC


The doccumentation at https://docs.python.org/3.10/library/weakref.html cautions that the `WeakKeyDictionary` and `WeakValueDictionary` are susceptible to the problem of dictionary mutation during iteration.

These notes present the user with a problem that has no easy solution.

I dug into the implementation and found that fortunately, Antoine Pitrou already addressed this challenge (10 years ago!) by introducing an `_IterationGuard` context manager to the implementation, which delays mutation while an iteration is in progress.

I asked for confirmation and @pitrou agreed that these notes could be removed:
https://github.com/python/cpython/commit/c1baa601e2b558deb690edfdf334fceee3b03327GH-commitcomment-39514438.
(cherry picked from commit 1642c0ef750f96664a98cadb09301d492098d2fb)

Co-authored-by: Daniel Fortunov <asqui@users.noreply.github.com>

Automerge-Triggered-By: @pitrou
1 parent c7a6c7b
History
Tip revision: 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC
[3.8] bpo-40895: Update weakref documentation to remove old warnings (GH-20687) (GH-20792)
Tip revision: 972aba8
File Mode Size
pgen
Python.asdl -rw-r--r-- 5.3 KB
acceler.c -rw-r--r-- 3.3 KB
asdl.py -rw-r--r-- 12.6 KB
asdl_c.py -rw-r--r-- 44.3 KB
grammar1.c -rw-r--r-- 1.0 KB
listnode.c -rw-r--r-- 1.2 KB
myreadline.c -rw-r--r-- 11.9 KB
node.c -rw-r--r-- 5.1 KB
parser.c -rw-r--r-- 12.4 KB
parser.h -rw-r--r-- 1.4 KB
parsetok.c -rw-r--r-- 14.2 KB
token.c -rw-r--r-- 4.5 KB
tokenizer.c -rw-r--r-- 55.9 KB
tokenizer.h -rw-r--r-- 3.7 KB

back to top