Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC, committed by GitHub on 10 June 2020, 20:38:42 UTC 
[3.8] bpo-40895: Update weakref documentation to remove old warnings (GH-20687) (GH-20792)
 


The doccumentation at https://docs.python.org/3.10/library/weakref.html cautions that the `WeakKeyDictionary` and `WeakValueDictionary` are susceptible to the problem of dictionary mutation during iteration.

These notes present the user with a problem that has no easy solution.

I dug into the implementation and found that fortunately, Antoine Pitrou already addressed this challenge (10 years ago!) by introducing an `_IterationGuard` context manager to the implementation, which delays mutation while an iteration is in progress.

I asked for confirmation and @pitrou agreed that these notes could be removed:
https://github.com/python/cpython/commit/c1baa601e2b558deb690edfdf334fceee3b03327GH-commitcomment-39514438.
(cherry picked from commit 1642c0ef750f96664a98cadb09301d492098d2fb)

Co-authored-by: Daniel Fortunov <asqui@users.noreply.github.com>

Automerge-Triggered-By: @pitrou
1 parent c7a6c7b
Raw File
Tip revision: 972aba86ede0bf254e16a760639a1ff8df298578 authored by Antoine Pitrou on 10 June 2020, 20:38:42 UTC
[3.8] bpo-40895: Update weakref documentation to remove old warnings (GH-20687) (GH-20792)
Tip revision: 972aba8
codecov.yml 
codecov:
  strict_yaml_branch: master
  notify:
    require_ci_to_pass: true
comment: off
ignore:
  - "Doc/**/*"
  - "Misc/**/*"
  - "Mac/**/*"
  - "PC/**/*"
  - "PCbuild/**/*"
  - "Tools/**/*"
  - "Grammar/*"
coverage:
  precision: 2
  range: 70...90
  round: down
  status:
    changes: off
    project: off
    patch: off
parsers:
  gcov:
    branch_detection:
      conditional: true
      loop: true
      macro: false
      method: false
  javascript:
    enable_partials: false
back to top