Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 97136d71a78a4b6b816f7e14acc52be426efcb6f authored by Miss Islington (bot) on 21 November 2020, 09:12:21 UTC, committed by GitHub on 21 November 2020, 09:12:21 UTC
* bpo-40791: Make compare_digest more constant-time. The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization. (This is change GH-1 from https://bugs.python.org/issue40791 .) (cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28) Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent 0762e09
Tip revision: 97136d71a78a4b6b816f7e14acc52be426efcb6f authored by Miss Islington (bot) on 21 November 2020, 09:12:21 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: 97136d7
| File | Mode | Size |
|---|---|---|
| clinic | ||
| Python-ast.c | -rw-r--r-- | 284.5 KB |
| README | -rw-r--r-- | 62 bytes |
| _warnings.c | -rw-r--r-- | 37.1 KB |
| asdl.c | -rw-r--r-- | 1.4 KB |
| ast.c | -rw-r--r-- | 189.0 KB |
| ast_opt.c | -rw-r--r-- | 23.4 KB |
| ast_unparse.c | -rw-r--r-- | 25.1 KB |
| bltinmodule.c | -rw-r--r-- | 82.9 KB |
| bootstrap_hash.c | -rw-r--r-- | 17.4 KB |
| ceval.c | -rw-r--r-- | 175.9 KB |
| ceval_gil.h | -rw-r--r-- | 8.4 KB |
| codecs.c | -rw-r--r-- | 44.9 KB |
| compile.c | -rw-r--r-- | 171.1 KB |
| condvar.h | -rw-r--r-- | 8.4 KB |
| context.c | -rw-r--r-- | 29.7 KB |
| dtoa.c | -rw-r--r-- | 77.8 KB |
| dup2.c | -rw-r--r-- | 759 bytes |
| dynamic_annotations.c | -rw-r--r-- | 6.6 KB |
| dynload_aix.c | -rw-r--r-- | 5.9 KB |
| dynload_dl.c | -rw-r--r-- | 581 bytes |
| dynload_hpux.c | -rw-r--r-- | 2.2 KB |
| dynload_shlib.c | -rw-r--r-- | 3.4 KB |
| dynload_stub.c | -rw-r--r-- | 186 bytes |
| dynload_win.c | -rw-r--r-- | 10.0 KB |
| errors.c | -rw-r--r-- | 43.6 KB |
| fileutils.c | -rw-r--r-- | 53.3 KB |
| formatter_unicode.c | -rw-r--r-- | 50.3 KB |
| frozen.c | -rw-r--r-- | 1.8 KB |
| frozenmain.c | -rw-r--r-- | 3.1 KB |
| future.c | -rw-r--r-- | 4.7 KB |
| getargs.c | -rw-r--r-- | 85.9 KB |
| getcompiler.c | -rw-r--r-- | 538 bytes |
| getcopyright.c | -rw-r--r-- | 511 bytes |
| getopt.c | -rw-r--r-- | 4.8 KB |
| getplatform.c | -rw-r--r-- | 133 bytes |
| getversion.c | -rw-r--r-- | 308 bytes |
| graminit.c | -rw-r--r-- | 53.2 KB |
| hamt.c | -rw-r--r-- | 79.0 KB |
| import.c | -rw-r--r-- | 66.1 KB |
| importdl.c | -rw-r--r-- | 7.3 KB |
| importdl.h | -rw-r--r-- | 487 bytes |
| importlib.h | -rw-r--r-- | 94.2 KB |
| importlib_external.h | -rw-r--r-- | 145.2 KB |
| importlib_zipimport.h | -rw-r--r-- | 57.7 KB |
| initconfig.c | -rw-r--r-- | 77.4 KB |
| makeopcodetargets.py | -rwxr-xr-x | 1.6 KB |
| marshal.c | -rw-r--r-- | 48.7 KB |
| modsupport.c | -rw-r--r-- | 17.7 KB |
| mysnprintf.c | -rw-r--r-- | 3.3 KB |
| mystrtoul.c | -rw-r--r-- | 8.1 KB |
| opcode_targets.h | -rw-r--r-- | 6.3 KB |
| pathconfig.c | -rw-r--r-- | 19.2 KB |
| peephole.c | -rw-r--r-- | 19.0 KB |
| preconfig.c | -rw-r--r-- | 24.4 KB |
| pyarena.c | -rw-r--r-- | 5.5 KB |
| pyctype.c | -rw-r--r-- | 7.7 KB |
| pyfpe.c | -rw-r--r-- | 345 bytes |
| pyhash.c | -rw-r--r-- | 13.2 KB |
| pylifecycle.c | -rw-r--r-- | 65.0 KB |
| pymath.c | -rw-r--r-- | 1.6 KB |
| pystate.c | -rw-r--r-- | 50.2 KB |
| pystrcmp.c | -rw-r--r-- | 753 bytes |
| pystrhex.c | -rw-r--r-- | 4.2 KB |
| pystrtod.c | -rw-r--r-- | 40.1 KB |
| pythonrun.c | -rw-r--r-- | 47.9 KB |
| pytime.c | -rw-r--r-- | 26.6 KB |
| strdup.c | -rw-r--r-- | 251 bytes |
| structmember.c | -rw-r--r-- | 8.6 KB |
| symtable.c | -rw-r--r-- | 63.6 KB |
| sysmodule.c | -rw-r--r-- | 92.8 KB |
| thread.c | -rw-r--r-- | 5.3 KB |
| thread_nt.h | -rw-r--r-- | 11.8 KB |
| thread_pthread.h | -rw-r--r-- | 23.7 KB |
| traceback.c | -rw-r--r-- | 24.7 KB |
| wordcode_helpers.h | -rw-r--r-- | 1.2 KB |
Computing file changes ...
