Staging
v0.5.1
https://github.com/python/cpython
Revision 97136d71a78a4b6b816f7e14acc52be426efcb6f authored by Miss Islington (bot) on 21 November 2020, 09:12:21 UTC, committed by GitHub on 21 November 2020, 09:12:21 UTC

* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change GH-1 from https://bugs.python.org/issue40791 .)
(cherry picked from commit 31729366e2bc09632e78f3896dbce0ae64914f28)

Co-authored-by: Devin Jeanpierre <jeanpierreda@google.com>
1 parent 0762e09
Raw File
Tip revision: 97136d71a78a4b6b816f7e14acc52be426efcb6f authored by Miss Islington (bot) on 21 November 2020, 09:12:21 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: 97136d7
CODE_OF_CONDUCT.md
# Code of Conduct

Please note that all interactions on
[Python Software Foundation](https://www.python.org/psf-landing/)-supported
infrastructure is [covered](https://www.python.org/psf/records/board/minutes/2014-01-06/#management-of-the-psfs-web-properties)
by the [PSF Code of Conduct](https://www.python.org/psf/codeofconduct/),
which includes all the infrastructure used in the development of Python itself
(e.g. mailing lists, issue trackers, GitHub, etc.).

In general, this means that everyone is expected to be **open**, **considerate**, and
**respectful** of others no matter what their position is within the project.

back to top