Staging
v0.8.1
https://github.com/python/cpython
Revision 961703cdc82536b6ff897ad7d4b3bbf22718d1b5 authored by Miss Islington (bot) on 16 July 2020, 13:25:31 UTC, committed by GitHub on 16 July 2020, 13:25:31 UTC

GCC says
```
../cpython/Parser/string_parser.c: In function ‘fstring_find_expr’:
../cpython/Parser/string_parser.c:404:93: warning: ‘cols’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  404 |     p2->starting_col_offset = p->tok->first_lineno == p->tok->lineno ? t->col_offset + cols : cols;
      |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
../cpython/Parser/string_parser.c:384:16: note: ‘cols’ was declared here
  384 |     int lines, cols;
      |                ^~~~
../cpython/Parser/string_parser.c:403:45: warning: ‘lines’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  403 |     p2->starting_lineno = t->lineno + lines - 1;
      |                           ~~~~~~~~~~~~~~~~~~^~~
../cpython/Parser/string_parser.c:384:9: note: ‘lines’ was declared here
  384 |     int lines, cols;
      |         ^~~~~
```

and, indeed, if `PyBytes_AsString` somehow fails, lines & cols will not be initialized.
(cherry picked from commit 2ad7e9c011b7606c5c7307176df07419a0e60134)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
1 parent f0f6566
History
Tip revision: 961703cdc82536b6ff897ad7d4b3bbf22718d1b5 authored by Miss Islington (bot) on 16 July 2020, 13:25:31 UTC
Fix possibly-unitialized warning in string_parser.c. (GH-21503)
Tip revision: 961703c
File Mode Size
clinic
stringlib
README -rw-r--r-- 41 bytes
abstract.c -rw-r--r-- 70.8 KB
accu.c -rw-r--r-- 2.4 KB
boolobject.c -rw-r--r-- 6.6 KB
bytearrayobject.c -rw-r--r-- 72.1 KB
bytes_methods.c -rw-r--r-- 21.2 KB
bytesobject.c -rw-r--r-- 99.6 KB
call.c -rw-r--r-- 29.0 KB
capsule.c -rw-r--r-- 7.3 KB
cellobject.c -rw-r--r-- 5.6 KB
classobject.c -rw-r--r-- 18.0 KB
codeobject.c -rw-r--r-- 35.0 KB
complexobject.c -rw-r--r-- 31.6 KB
descrobject.c -rw-r--r-- 60.9 KB
dict-common.h -rw-r--r-- 2.2 KB
dictnotes.txt -rw-r--r-- 6.0 KB
dictobject.c -rw-r--r-- 142.1 KB
enumobject.c -rw-r--r-- 13.6 KB
exceptions.c -rw-r--r-- 87.4 KB
fileobject.c -rw-r--r-- 16.9 KB
floatobject.c -rw-r--r-- 69.5 KB
frameobject.c -rw-r--r-- 35.9 KB
funcobject.c -rw-r--r-- 31.0 KB
genericaliasobject.c -rw-r--r-- 15.8 KB
genobject.c -rw-r--r-- 66.3 KB
interpreteridobject.c -rw-r--r-- 8.6 KB
iterobject.c -rw-r--r-- 9.1 KB
listobject.c -rw-r--r-- 98.2 KB
listsort.txt -rw-r--r-- 35.3 KB
lnotab_notes.txt -rw-r--r-- 5.9 KB
longobject.c -rw-r--r-- 174.3 KB
memoryobject.c -rw-r--r-- 91.7 KB
methodobject.c -rw-r--r-- 16.9 KB
moduleobject.c -rw-r--r-- 24.8 KB
namespaceobject.c -rw-r--r-- 7.4 KB
object.c -rw-r--r-- 60.9 KB
obmalloc.c -rw-r--r-- 88.0 KB
odictobject.c -rw-r--r-- 73.6 KB
picklebufobject.c -rw-r--r-- 6.0 KB
rangeobject.c -rw-r--r-- 35.6 KB
setobject.c -rw-r--r-- 72.1 KB
sliceobject.c -rw-r--r-- 19.1 KB
structseq.c -rw-r--r-- 14.9 KB
tupleobject.c -rw-r--r-- 31.6 KB
typeobject.c -rw-r--r-- 252.3 KB
typeslots.inc -rw-r--r-- 4.0 KB
typeslots.py -rwxr-xr-x 1.2 KB
unicodectype.c -rw-r--r-- 7.5 KB
unicodeobject.c -rw-r--r-- 470.0 KB
unicodetype_db.h -rw-r--r-- 249.6 KB
weakrefobject.c -rw-r--r-- 31.5 KB

README

back to top