Staging
v0.5.1
v0.5.1
https://github.com/torvalds/linux
Revision 8d6c83f0ba5e1bd1e8bb2e3c7de4c276dc247f99 authored by KOSAKI Motohiro on 19 August 2010, 21:13:39 UTC, committed by Linus Torvalds on 20 August 2010, 16:34:55 UTC
dump_tasks() needs to hold the RCU read lock around its access of the target task's UID. To this end it should use task_uid() as it only needs that one thing from the creds. The fact that dump_tasks() holds tasklist_lock is insufficient to prevent the target process replacing its credentials on another CPU. Then, this patch change to call rcu_read_lock() explicitly. =================================================== [ INFO: suspicious rcu_dereference_check() usage. ] --------------------------------------------------- mm/oom_kill.c:410 invoked rcu_dereference_check() without protection! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 1 4 locks held by kworker/1:2/651: #0: (events){+.+.+.}, at: [<ffffffff8106aae7>] process_one_work+0x137/0x4a0 #1: (moom_work){+.+...}, at: [<ffffffff8106aae7>] process_one_work+0x137/0x4a0 #2: (tasklist_lock){.+.+..}, at: [<ffffffff810fafd4>] out_of_memory+0x164/0x3f0 #3: (&(&p->alloc_lock)->rlock){+.+...}, at: [<ffffffff810fa48e>] find_lock_task_mm+0x2e/0x70 Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent b52723c
Tip revision: 8d6c83f0ba5e1bd1e8bb2e3c7de4c276dc247f99 authored by KOSAKI Motohiro on 19 August 2010, 21:13:39 UTC
oom: __task_cred() need rcu_read_lock()
oom: __task_cred() need rcu_read_lock()
Tip revision: 8d6c83f
File | Mode | Size |
---|---|---|
Makefile | -rw-r--r-- | 394 bytes |
compat.c | -rw-r--r-- | 16.9 KB |
compat_mq.c | -rw-r--r-- | 4.0 KB |
ipc_sysctl.c | -rw-r--r-- | 5.1 KB |
ipcns_notifier.c | -rw-r--r-- | 2.2 KB |
mq_sysctl.c | -rw-r--r-- | 2.7 KB |
mqueue.c | -rw-r--r-- | 30.3 KB |
msg.c | -rw-r--r-- | 20.8 KB |
msgutil.c | -rw-r--r-- | 2.8 KB |
namespace.c | -rw-r--r-- | 3.3 KB |
sem.c | -rw-r--r-- | 40.3 KB |
shm.c | -rw-r--r-- | 25.8 KB |
syscall.c | -rw-r--r-- | 2.3 KB |
util.c | -rw-r--r-- | 22.9 KB |
util.h | -rw-r--r-- | 5.2 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...