Staging
v0.8.1
v0.8.1
https://github.com/torvalds/linux
Revision 8d6c83f0ba5e1bd1e8bb2e3c7de4c276dc247f99 authored by KOSAKI Motohiro on 19 August 2010, 21:13:39 UTC, committed by Linus Torvalds on 20 August 2010, 16:34:55 UTC
dump_tasks() needs to hold the RCU read lock around its access of the target task's UID. To this end it should use task_uid() as it only needs that one thing from the creds. The fact that dump_tasks() holds tasklist_lock is insufficient to prevent the target process replacing its credentials on another CPU. Then, this patch change to call rcu_read_lock() explicitly. =================================================== [ INFO: suspicious rcu_dereference_check() usage. ] --------------------------------------------------- mm/oom_kill.c:410 invoked rcu_dereference_check() without protection! other info that might help us debug this: rcu_scheduler_active = 1, debug_locks = 1 4 locks held by kworker/1:2/651: #0: (events){+.+.+.}, at: [<ffffffff8106aae7>] process_one_work+0x137/0x4a0 #1: (moom_work){+.+...}, at: [<ffffffff8106aae7>] process_one_work+0x137/0x4a0 #2: (tasklist_lock){.+.+..}, at: [<ffffffff810fafd4>] out_of_memory+0x164/0x3f0 #3: (&(&p->alloc_lock)->rlock){+.+...}, at: [<ffffffff810fa48e>] find_lock_task_mm+0x2e/0x70 Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: David Howells <dhowells@redhat.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Acked-by: David Rientjes <rientjes@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent b52723c
Tip revision: 8d6c83f0ba5e1bd1e8bb2e3c7de4c276dc247f99 authored by KOSAKI Motohiro on 19 August 2010, 21:13:39 UTC
oom: __task_cred() need rcu_read_lock()
oom: __task_cred() need rcu_read_lock()
Tip revision: 8d6c83f
File | Mode | Size |
---|---|---|
Kconfig | -rw-r--r-- | 2.5 KB |
Kconfig.iosched | -rw-r--r-- | 1.8 KB |
Makefile | -rw-r--r-- | 592 bytes |
blk-barrier.c | -rw-r--r-- | 8.6 KB |
blk-cgroup.c | -rw-r--r-- | 26.8 KB |
blk-cgroup.h | -rw-r--r-- | 8.0 KB |
blk-core.c | -rw-r--r-- | 69.0 KB |
blk-exec.c | -rw-r--r-- | 2.6 KB |
blk-integrity.c | -rw-r--r-- | 10.0 KB |
blk-ioc.c | -rw-r--r-- | 3.9 KB |
blk-iopoll.c | -rw-r--r-- | 5.9 KB |
blk-lib.c | -rw-r--r-- | 5.1 KB |
blk-map.c | -rw-r--r-- | 8.1 KB |
blk-merge.c | -rw-r--r-- | 10.6 KB |
blk-settings.c | -rw-r--r-- | 25.1 KB |
blk-softirq.c | -rw-r--r-- | 4.1 KB |
blk-sysfs.c | -rw-r--r-- | 14.0 KB |
blk-tag.c | -rw-r--r-- | 9.9 KB |
blk-timeout.c | -rw-r--r-- | 5.6 KB |
blk.h | -rw-r--r-- | 4.6 KB |
bsg.c | -rw-r--r-- | 23.5 KB |
cfq-iosched.c | -rw-r--r-- | 101.7 KB |
cfq.h | -rw-r--r-- | 3.6 KB |
compat_ioctl.c | -rw-r--r-- | 21.0 KB |
deadline-iosched.c | -rw-r--r-- | 11.4 KB |
elevator.c | -rw-r--r-- | 25.1 KB |
genhd.c | -rw-r--r-- | 29.9 KB |
ioctl.c | -rw-r--r-- | 8.0 KB |
noop-iosched.c | -rw-r--r-- | 2.6 KB |
scsi_ioctl.c | -rw-r--r-- | 18.0 KB |
Computing file changes ...