Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 8c354ac51357700e26c1731eb88f8246e184e7f8 authored by Raymond Hettinger on 06 October 2002, 05:43:47 UTC, committed by Raymond Hettinger on 06 October 2002, 05:43:47 UTC
SF #558432: Prevent Annoying ' ' from readline (Holker Krekel).
readline in all python versions is configured
to append a 'space' character for a successful
completion. But for almost all python expressions
'space' is not wanted (see coding conventions PEP 8).
For example if you have a function 'longfunction'
and you type 'longf<TAB>' you get 'longfunction '
as a completion. note the unwanted space at the
end.
The patch fixes this behaviour by setting readline's
append_character to '\0' which means don't append
anything. This doesn't work with readline < 2.1
(AFAIK nowadays readline2.2 is in good use).
An alternative approach would be to make the
append_character
accessable from python so that modules like
the rlcompleter.py can set it to '\0'.
[Ed.: I think expecting readline >= 2.2 is fine. If a completer wants
another character they can append that to the keyword in the list.]
1 parent f29109a
Tip revision: 8c354ac51357700e26c1731eb88f8246e184e7f8 authored by Raymond Hettinger on 06 October 2002, 05:43:47 UTC
Backport 2.49:
Backport 2.49:
Tip revision: 8c354ac
| File | Mode | Size |
|---|---|---|
| .cvsignore | -rw-r--r-- | 22 bytes |
| acceler.c | -rw-r--r-- | 3.2 KB |
| bitset.c | -rw-r--r-- | 949 bytes |
| firstsets.c | -rw-r--r-- | 2.1 KB |
| grammar.c | -rw-r--r-- | 4.6 KB |
| grammar.mak | -rw-r--r-- | 1.1 KB |
| grammar1.c | -rw-r--r-- | 1.0 KB |
| intrcheck.c | -rw-r--r-- | 2.8 KB |
| listnode.c | -rw-r--r-- | 983 bytes |
| metagrammar.c | -rw-r--r-- | 2.1 KB |
| myreadline.c | -rw-r--r-- | 2.9 KB |
| node.c | -rw-r--r-- | 2.4 KB |
| parser.c | -rw-r--r-- | 8.7 KB |
| parser.h | -rw-r--r-- | 966 bytes |
| parsetok.c | -rw-r--r-- | 4.1 KB |
| pgen.c | -rw-r--r-- | 14.2 KB |
| pgen.h | -rw-r--r-- | 253 bytes |
| pgenmain.c | -rw-r--r-- | 3.6 KB |
| printgrammar.c | -rw-r--r-- | 2.4 KB |
| tokenizer.c | -rw-r--r-- | 17.9 KB |
| tokenizer.h | -rw-r--r-- | 1.8 KB |
Computing file changes ...
