Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 749afe81ec0a4b92ad6b89a67c82f2c04f79c5ac authored by CtrlZvi on 25 May 2018, 08:03:25 UTC, committed by Andrew Svetlov on 25 May 2018, 08:03:25 UTC
The proactor event loop has a race condition when reading with pausing/resuming. `resume_reading()` unconditionally schedules the read function to read from the current future. If `resume_reading()` was called before the previously scheduled done callback fires, this results in two attempts to get the data from the most recent read and an assertion failure. This commit tracks whether or not `resume_reading` needs to reschedule the callback to restart the loop, preventing a second attempt to read the data.. (cherry picked from commit 4151061855b571bf8a7579daa7875b8e243057b9) Co-authored-by: CtrlZvi <viz+github@flippedperspective.com>
1 parent 36f066a
Tip revision: 749afe81ec0a4b92ad6b89a67c82f2c04f79c5ac authored by CtrlZvi on 25 May 2018, 08:03:25 UTC
[3.6] bpo-26819: Prevent proactor double read on resume (GH-6921) (#7110)
[3.6] bpo-26819: Prevent proactor double read on resume (GH-6921) (#7110)
Tip revision: 749afe8
| File | Mode | Size |
|---|---|---|
| clinic | ||
| Python-ast.c | -rw-r--r-- | 262.9 KB |
| README | -rw-r--r-- | 62 bytes |
| _warnings.c | -rw-r--r-- | 35.3 KB |
| asdl.c | -rw-r--r-- | 1.4 KB |
| ast.c | -rw-r--r-- | 160.4 KB |
| bltinmodule.c | -rw-r--r-- | 80.9 KB |
| ceval.c | -rw-r--r-- | 171.3 KB |
| ceval_gil.h | -rw-r--r-- | 8.9 KB |
| codecs.c | -rw-r--r-- | 45.0 KB |
| compile.c | -rw-r--r-- | 150.6 KB |
| condvar.h | -rw-r--r-- | 11.0 KB |
| dtoa.c | -rw-r--r-- | 78.5 KB |
| dup2.c | -rw-r--r-- | 705 bytes |
| dynamic_annotations.c | -rw-r--r-- | 6.6 KB |
| dynload_aix.c | -rw-r--r-- | 5.7 KB |
| dynload_dl.c | -rw-r--r-- | 581 bytes |
| dynload_hpux.c | -rw-r--r-- | 1.9 KB |
| dynload_next.c | -rw-r--r-- | 3.9 KB |
| dynload_shlib.c | -rw-r--r-- | 3.3 KB |
| dynload_stub.c | -rw-r--r-- | 186 bytes |
| dynload_win.c | -rw-r--r-- | 10.0 KB |
| errors.c | -rw-r--r-- | 32.1 KB |
| fileutils.c | -rw-r--r-- | 45.9 KB |
| formatter_unicode.c | -rw-r--r-- | 49.7 KB |
| frozen.c | -rw-r--r-- | 1.7 KB |
| frozenmain.c | -rw-r--r-- | 2.7 KB |
| future.c | -rw-r--r-- | 4.9 KB |
| getargs.c | -rw-r--r-- | 72.2 KB |
| getcompiler.c | -rw-r--r-- | 369 bytes |
| getcopyright.c | -rw-r--r-- | 511 bytes |
| getopt.c | -rw-r--r-- | 3.4 KB |
| getplatform.c | -rw-r--r-- | 130 bytes |
| getversion.c | -rw-r--r-- | 289 bytes |
| graminit.c | -rw-r--r-- | 43.3 KB |
| import.c | -rw-r--r-- | 57.8 KB |
| importdl.c | -rw-r--r-- | 7.1 KB |
| importdl.h | -rw-r--r-- | 487 bytes |
| importlib.h | -rw-r--r-- | 96.2 KB |
| importlib_external.h | -rw-r--r-- | 129.7 KB |
| makeopcodetargets.py | -rwxr-xr-x | 1.6 KB |
| marshal.c | -rw-r--r-- | 50.3 KB |
| modsupport.c | -rw-r--r-- | 14.8 KB |
| mysnprintf.c | -rw-r--r-- | 3.3 KB |
| mystrtoul.c | -rw-r--r-- | 8.1 KB |
| opcode_targets.h | -rw-r--r-- | 6.3 KB |
| peephole.c | -rw-r--r-- | 30.6 KB |
| pyarena.c | -rw-r--r-- | 5.5 KB |
| pyctype.c | -rw-r--r-- | 7.7 KB |
| pyfpe.c | -rw-r--r-- | 621 bytes |
| pyhash.c | -rw-r--r-- | 13.0 KB |
| pylifecycle.c | -rw-r--r-- | 46.2 KB |
| pymath.c | -rw-r--r-- | 1.5 KB |
| pystate.c | -rw-r--r-- | 27.4 KB |
| pystrcmp.c | -rw-r--r-- | 613 bytes |
| pystrhex.c | -rw-r--r-- | 1.6 KB |
| pystrtod.c | -rw-r--r-- | 40.1 KB |
| pythonrun.c | -rw-r--r-- | 43.1 KB |
| pytime.c | -rw-r--r-- | 19.8 KB |
| random.c | -rw-r--r-- | 17.7 KB |
| sigcheck.c | -rw-r--r-- | 529 bytes |
| strdup.c | -rw-r--r-- | 247 bytes |
| structmember.c | -rw-r--r-- | 8.6 KB |
| symtable.c | -rw-r--r-- | 56.8 KB |
| sysmodule.c | -rw-r--r-- | 70.0 KB |
| thread.c | -rw-r--r-- | 12.4 KB |
| thread_foobar.h | -rw-r--r-- | 2.2 KB |
| thread_nt.h | -rw-r--r-- | 9.6 KB |
| thread_pthread.h | -rw-r--r-- | 17.8 KB |
| traceback.c | -rw-r--r-- | 21.9 KB |
| wordcode_helpers.h | -rw-r--r-- | 1.2 KB |
Computing file changes ...
