Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 6f7346bb3983cd7a6aa97eeeafffb3cecd5292b8 authored by Victor Stinner on 03 June 2020, 16:28:18 UTC, committed by GitHub on 03 June 2020, 16:28:18 UTC 
[3.9] bpo-40826: Fix GIL usage in PyOS_Readline() (GH-20613) (GH-20616)
 
* bpo-40826: Fix GIL usage in PyOS_Readline() (GH-20579)

Fix GIL usage in PyOS_Readline(): lock the GIL to set an exception.

Pass tstate to my_fgets() and _PyOS_WindowsConsoleReadline(). Cleanup
these functions.

(cherry picked from commit c353764fd564e401cf47a5d9efab18c72c60014e)

* bpo-40826: Add _PyOS_InterruptOccurred(tstate) function (GH-20599)

my_fgets() now calls _PyOS_InterruptOccurred(tstate) to check for
pending signals, rather calling PyOS_InterruptOccurred().

my_fgets() is called with the GIL released, whereas
PyOS_InterruptOccurred() must be called with the GIL held.

test_repl: use text=True and avoid SuppressCrashReport in
test_multiline_string_parsing().

Fix my_fgets() on Windows: fgets(fp) does crash if fileno(fp) is closed.

(cherry picked from commit fa7ab6aa0f9a4f695e5525db5a113cd21fa93787)
1 parent 5b8787e
History
Tip revision: 6f7346bb3983cd7a6aa97eeeafffb3cecd5292b8 authored by Victor Stinner on 03 June 2020, 16:28:18 UTC
[3.9] bpo-40826: Fix GIL usage in PyOS_Readline() (GH-20613) (GH-20616)
Tip revision: 6f7346b
File Mode Size
README -rw-r--r-- 67 bytes
_freeze_importlib.c -rw-r--r-- 4.7 KB
_testembed.c -rw-r--r-- 42.7 KB
python.c -rw-r--r-- 298 bytes

README

back to top