Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision 4590f72259ecbcea66e12a28af14d867255d2e66 authored by Eddie Elizondo on 04 February 2020, 10:29:25 UTC, committed by GitHub on 04 February 2020, 10:29:25 UTC
Currently, during runtime destruction, `_PyImport_Cleanup` is clearing the interpreter state before clearing out the modules themselves. This leads to a segfault on modules that rely on the module state to clear themselves up. For example, let's take the small snippet added in the issue by @DinoV : ``` import _struct class C: def __init__(self): self.pack = _struct.pack def __del__(self): self.pack('I', -42) _struct.x = C() ``` The module `_struct` uses the module state to run `pack`. Therefore, the module state has to be alive until after the module has been cleared out to successfully run `C.__del__`. This happens at line 606, when `_PyImport_Cleanup` calls `_PyModule_Clear`. In fact, the loop that calls `_PyModule_Clear` has in its comments: > Now, if there are any modules left alive, clear their globals to minimize potential leaks. All C extension modules actually end up here, since they are kept alive in the interpreter state. That means that we can't clear the module state (which is used by C Extensions) before we run that loop. Moving `_PyInterpreterState_ClearModules` until after it, fixes the segfault in the code snippet. Finally, this updates a test in `io` to correctly assert the error that it now throws (since it now finds the io module state). The test that uses this is: `test_create_at_shutdown_without_encoding`. Given this test is now working is a proof that the module state now stays alive even when `__del__` is called at module destruction time. Thus, I didn't add a new tests for this. https://bugs.python.org/issue38076
1 parent b6999e5
Tip revision: 4590f72259ecbcea66e12a28af14d867255d2e66 authored by Eddie Elizondo on 04 February 2020, 10:29:25 UTC
bpo-38076 Clear the interpreter state only after clearing module globals (GH-18039)
bpo-38076 Clear the interpreter state only after clearing module globals (GH-18039)
Tip revision: 4590f72
File | Mode | Size |
---|---|---|
.azure-pipelines | ||
.github | ||
Doc | ||
Grammar | ||
Include | ||
Lib | ||
Mac | ||
Misc | ||
Modules | ||
Objects | ||
PC | ||
PCbuild | ||
Parser | ||
Programs | ||
Python | ||
Tools | ||
m4 | ||
.gitattributes | -rw-r--r-- | 1.8 KB |
.gitignore | -rw-r--r-- | 1.8 KB |
.travis.yml | -rw-r--r-- | 8.1 KB |
CODE_OF_CONDUCT.md | -rw-r--r-- | 630 bytes |
LICENSE | -rw-r--r-- | 12.5 KB |
Makefile.pre.in | -rw-r--r-- | 66.5 KB |
README.rst | -rw-r--r-- | 9.9 KB |
aclocal.m4 | -rw-r--r-- | 10.7 KB |
config.guess | -rwxr-xr-x | 43.1 KB |
config.sub | -rwxr-xr-x | 35.4 KB |
configure | -rwxr-xr-x | 494.1 KB |
configure.ac | -rw-r--r-- | 164.8 KB |
install-sh | -rwxr-xr-x | 15.0 KB |
netlify.toml | -rw-r--r-- | 82 bytes |
pyconfig.h.in | -rw-r--r-- | 44.0 KB |
setup.py | -rw-r--r-- | 101.7 KB |
Computing file changes ...