Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 39a8fddb1507593ebc8449ddcecd30ddaca69931 authored by Barry Warsaw on 28 May 2003, 23:03:30 UTC, committed by Barry Warsaw on 28 May 2003, 23:03:30 UTC
SF 742860: WeakKeyDictionary __delitem__ uses iterkeys
Someone review this, please! Final releases are getting close, Fred
(the weakref guy) won't be around until Tuesday, and the pre-patch
code can indeed raise spurious RuntimeErrors in the presence of
threads or mutating comparison functions.
See the bug report for my confusions: I can't see any reason for why
__delitem__ iterated over the keys. The new one-liner implementation
is much faster, can't raise RuntimeError, and should be better-behaved
in all respects wrt threads.
New tests test_weak_keyed_bad_delitem and
test_weak_keyed_cascading_deletes fail before this patch.
Backported the tests and the patch.
1 parent 7496e18
Tip revision: 39a8fddb1507593ebc8449ddcecd30ddaca69931 authored by Barry Warsaw on 28 May 2003, 23:03:30 UTC
The backport gets Fred's seal of approval:
The backport gets Fred's seal of approval:
Tip revision: 39a8fdd
| File | Mode | Size |
|---|---|---|
| example_nt | ||
| os2vacpp | ||
| WinMain.c | -rw-r--r-- | 482 bytes |
| _winreg.c | -rw-r--r-- | 41.9 KB |
| config.c | -rw-r--r-- | 2.9 KB |
| dl_nt.c | -rw-r--r-- | 908 bytes |
| dllbase_nt.txt | -rw-r--r-- | 3.2 KB |
| frozen_dllmain.c | -rw-r--r-- | 3.6 KB |
| getpathp.c | -rw-r--r-- | 16.4 KB |
| import_nt.c | -rw-r--r-- | 2.4 KB |
| msvcrtmodule.c | -rwxr-xr-x | 4.8 KB |
| py.ico | -rw-r--r-- | 766 bytes |
| pyc.ico | -rw-r--r-- | 766 bytes |
| pycon.ico | -rw-r--r-- | 766 bytes |
| pyconfig.h | -rw-r--r-- | 17.6 KB |
| python.mk | -rw-r--r-- | 234 bytes |
| python_exe.rc | -rw-r--r-- | 49 bytes |
| python_nt.rc | -rw-r--r-- | 2.7 KB |
| readme.txt | -rw-r--r-- | 4.1 KB |
| testpy.py | -rw-r--r-- | 850 bytes |
| w9xpopen.c | -rw-r--r-- | 1.7 KB |
| winsound.c | -rw-r--r-- | 6.5 KB |
Computing file changes ...
