Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 39a8fddb1507593ebc8449ddcecd30ddaca69931 authored by Barry Warsaw on 28 May 2003, 23:03:30 UTC, committed by Barry Warsaw on 28 May 2003, 23:03:30 UTC 
The backport gets Fred's seal of approval:
 
    SF 742860: WeakKeyDictionary __delitem__ uses iterkeys

    Someone review this, please!  Final releases are getting close, Fred
    (the weakref guy) won't be around until Tuesday, and the pre-patch
    code can indeed raise spurious RuntimeErrors in the presence of
    threads or mutating comparison functions.

    See the bug report for my confusions:  I can't see any reason for why
    __delitem__ iterated over the keys.  The new one-liner implementation
    is much faster, can't raise RuntimeError, and should be better-behaved
    in all respects wrt threads.

    New tests test_weak_keyed_bad_delitem and
    test_weak_keyed_cascading_deletes fail before this patch.

Backported the tests and the patch.
1 parent 7496e18
History
Tip revision: 39a8fddb1507593ebc8449ddcecd30ddaca69931 authored by Barry Warsaw on 28 May 2003, 23:03:30 UTC
The backport gets Fred's seal of approval:
Tip revision: 39a8fdd
File Mode Size
(vise)
binary.exclude -rw-r--r-- 253 bytes
binary.include -rw-r--r-- 7.0 KB
dev.exclude -rw-r--r-- 129 bytes
dev.include -rw-r--r-- 20.4 KB
readme.txt -rw-r--r-- 2.6 KB
src.exclude -rw-r--r-- 150 bytes
src.include -rw-r--r-- 3.8 KB

readme.txt

back to top