Staging
v0.8.1
v0.8.1
Revision 34d316c21ceacefe460a55878dea690d5ec16caf authored by Anthony Baxter on 30 April 2002, 04:01:21 UTC, committed by Anthony Baxter on 30 April 2002, 04:01:21 UTC
Repair widespread misuse of _PyString_Resize. Since it's clear people don't understand how this function works, also beefed up the docs. The most common usage error is of this form (often spread out across gotos): if (_PyString_Resize(&s, n) < 0) { Py_DECREF(s); s = NULL; goto outtahere; } The error is that if _PyString_Resize runs out of memory, it automatically decrefs the input string object s (which also deallocates it, since its refcount must be 1 upon entry), and sets s to NULL. So if the "if" branch ever triggers, it's an error to call Py_DECREF(s): s is already NULL! A correct way to write the above is the simpler (and intended) if (_PyString_Resize(&s, n) < 0) goto outtahere; Bugfix candidate. Original patch(es): python/dist/src/Python/bltinmodule.c:2.253
1 parent 88c646e
File | Mode | Size |
---|---|---|
Demo | ||
Doc | ||
Grammar | ||
Include | ||
Lib | ||
Mac | ||
Misc | ||
Modules | ||
Objects | ||
PC | ||
PCbuild | ||
Parser | ||
Python | ||
RISCOS | ||
Tools | ||
.cvsignore | -rw-r--r-- | 79 bytes |
.hgtags | -rw-r--r-- | 2.3 KB |
LICENSE | -rw-r--r-- | 11.5 KB |
Makefile.pre.in | -rw-r--r-- | 21.8 KB |
README | -rw-r--r-- | 38.8 KB |
acconfig.h | -rw-r--r-- | 6.3 KB |
config.h.in | -rw-r--r-- | 17.1 KB |
configure | -rwxr-xr-x | 181.7 KB |
configure.in | -rw-r--r-- | 38.2 KB |
install-sh | -rwxr-xr-x | 5.5 KB |
setup.py | -rw-r--r-- | 25.2 KB |
Computing file changes ...