Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 31729366e2bc09632e78f3896dbce0ae64914f28 authored by Devin Jeanpierre on 21 November 2020, 08:55:23 UTC, committed by GitHub on 21 November 2020, 08:55:23 UTC 
bpo-40791: Make compare_digest more constant-time. (GH-20444)
 
* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change #1 from https://bugs.python.org/issue40791 .)
1 parent aa3a352
History
Tip revision: 31729366e2bc09632e78f3896dbce0ae64914f28 authored by Devin Jeanpierre on 21 November 2020, 08:55:23 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: 3172936
File Mode Size
Python.asdl -rw-r--r-- 5.2 KB
asdl.py -rw-r--r-- 12.7 KB
asdl_c.py -rwxr-xr-x 51.4 KB
myreadline.c -rw-r--r-- 11.6 KB
parser.c -rw-r--r-- 836.9 KB
peg_api.c -rw-r--r-- 2.2 KB
pegen.c -rw-r--r-- 61.7 KB
pegen.h -rw-r--r-- 10.0 KB
string_parser.c -rw-r--r-- 38.6 KB
string_parser.h -rw-r--r-- 1.8 KB
token.c -rw-r--r-- 4.5 KB
tokenizer.c -rw-r--r-- 56.9 KB
tokenizer.h -rw-r--r-- 3.8 KB
back to top