Skip to main content

Browse the archive

Staging
v0.8.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 31729366e2bc09632e78f3896dbce0ae64914f28 authored by Devin Jeanpierre on 21 November 2020, 08:55:23 UTC, committed by GitHub on 21 November 2020, 08:55:23 UTC 
bpo-40791: Make compare_digest more constant-time. (GH-20444)
 
* bpo-40791: Make compare_digest more constant-time.

The existing volatile `left`/`right` pointers guarantee that the reads will all occur, but does not guarantee that they will be _used_. So a compiler can still short-circuit the loop, saving e.g. the overhead of doing the xors and especially the overhead of the data dependency between `result` and the reads. That would change performance depending on where the first unequal byte occurs. This change removes that optimization.

(This is change #1 from https://bugs.python.org/issue40791 .)
1 parent aa3a352
History
Tip revision: 31729366e2bc09632e78f3896dbce0ae64914f28 authored by Devin Jeanpierre on 21 November 2020, 08:55:23 UTC
bpo-40791: Make compare_digest more constant-time. (GH-20444)
Tip revision: 3172936
File Mode Size
darwin
libffi_osx
_ctypes.c -rw-r--r-- 185.1 KB
_ctypes_test.c -rw-r--r-- 21.6 KB
_ctypes_test.h -rw-r--r-- 82 bytes
callbacks.c -rw-r--r-- 18.1 KB
callproc.c -rw-r--r-- 58.5 KB
cfield.c -rw-r--r-- 42.2 KB
ctypes.h -rw-r--r-- 13.1 KB
ctypes_dlfcn.h -rw-r--r-- 459 bytes
malloc_closure.c -rw-r--r-- 3.2 KB
stgdict.c -rw-r--r-- 31.3 KB
back to top