Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 30e769382dfb67a68fe8e6bfe8509addb4aa9514 authored by Miss Islington (bot) on 04 February 2020, 21:41:55 UTC, committed by GitHub on 04 February 2020, 21:41:55 UTC
When called on a closed object, readinto() segfaults on account of a write to a freed buffer: ==220553== Process terminating with default action of signal 11 (SIGSEGV): dumping core ==220553== Access not within mapped region at address 0x2A ==220553== at 0x48408A0: memmove (vg_replace_strmem.c:1272) ==220553== by 0x58DB0C: _buffered_readinto_generic (bufferedio.c:972) ==220553== by 0x58DCBA: _io__Buffered_readinto_impl (bufferedio.c:1053) ==220553== by 0x58DCBA: _io__Buffered_readinto (bufferedio.c.h:253) Reproducer: reader = open ("/dev/zero", "rb") _void = reader.read (42) reader.close () reader.readinto (bytearray (42)) GH-GH-GH- BANG! The problem exists since 2012 when commit dc469454ec added code to free the read buffer on close(). Signed-off-by: Philipp Gesang <philipp.gesang@intra2net.com> (cherry picked from commit cb1c0746f277052e45a60d6c436a765e34722821) Co-authored-by: Philipp Gesang <phg@phi-gamma.net>
1 parent 9a740b6
Tip revision: 30e769382dfb67a68fe8e6bfe8509addb4aa9514 authored by Miss Islington (bot) on 04 February 2020, 21:41:55 UTC
closes bpo-39510: Fix use-after-free in BufferedReader.readinto() (GH-18295)
closes bpo-39510: Fix use-after-free in BufferedReader.readinto() (GH-18295)
Tip revision: 30e7693
File | Mode | Size |
---|---|---|
pgen | ||
Python.asdl | -rw-r--r-- | 5.3 KB |
acceler.c | -rw-r--r-- | 3.3 KB |
asdl.py | -rw-r--r-- | 12.6 KB |
asdl_c.py | -rw-r--r-- | 43.5 KB |
grammar1.c | -rw-r--r-- | 1.0 KB |
listnode.c | -rw-r--r-- | 1.2 KB |
myreadline.c | -rw-r--r-- | 10.6 KB |
node.c | -rw-r--r-- | 5.1 KB |
parser.c | -rw-r--r-- | 12.4 KB |
parser.h | -rw-r--r-- | 1.4 KB |
parsetok.c | -rw-r--r-- | 14.2 KB |
token.c | -rw-r--r-- | 4.5 KB |
tokenizer.c | -rw-r--r-- | 55.1 KB |
tokenizer.h | -rw-r--r-- | 3.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...