Staging
v0.5.1
v0.5.1
https://github.com/git/git
Revision 2c778210f8877e8f5c88715c2d25d1a43d976566 authored by Christian Couder on 16 February 2008, 04:59:53 UTC, committed by Junio C Hamano on 16 February 2008, 05:24:53 UTC
It is not necessary to check if value != NULL before calling 'parse_lldiff_command' as there is already a check inside this function. By the way this patch also improves the existing check inside 'parse_lldiff_command' by using: return config_error_nonbool(var); instead of: return error("%s: lacks value", var); Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent e8b32e0
Tip revision: 2c778210f8877e8f5c88715c2d25d1a43d976566 authored by Christian Couder on 16 February 2008, 04:59:53 UTC
diff.c: remove useless check for value != NULL
diff.c: remove useless check for value != NULL
Tip revision: 2c77821
builtin-update-ref.c
#include "cache.h"
#include "refs.h"
#include "builtin.h"
#include "parse-options.h"
static const char * const git_update_ref_usage[] = {
"git-update-ref [options] -d <refname> <oldval>",
"git-update-ref [options] <refname> <newval> [<oldval>]",
NULL
};
int cmd_update_ref(int argc, const char **argv, const char *prefix)
{
const char *refname, *value, *oldval, *msg=NULL;
unsigned char sha1[20], oldsha1[20];
int delete = 0, no_deref = 0;
struct option options[] = {
OPT_STRING( 'm', NULL, &msg, "reason", "reason of the update"),
OPT_BOOLEAN('d', NULL, &delete, "deletes the reference"),
OPT_BOOLEAN( 0 , "no-deref", &no_deref,
"update <refname> not the one it points to"),
OPT_END(),
};
git_config(git_default_config);
argc = parse_options(argc, argv, options, git_update_ref_usage, 0);
if (msg && !*msg)
die("Refusing to perform update with empty message.");
if (argc < 2 || argc > 3)
usage_with_options(git_update_ref_usage, options);
refname = argv[0];
value = argv[1];
oldval = argv[2];
if (get_sha1(value, sha1))
die("%s: not a valid SHA1", value);
if (delete) {
if (oldval)
usage_with_options(git_update_ref_usage, options);
return delete_ref(refname, sha1);
}
hashclr(oldsha1);
if (oldval && *oldval && get_sha1(oldval, oldsha1))
die("%s: not a valid old SHA1", oldval);
return update_ref(msg, refname, sha1, oldval ? oldsha1 : NULL,
no_deref ? REF_NODEREF : 0, DIE_ON_ERR);
}
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...