Staging
v0.5.2
https://github.com/git/git
Revision 283884422f35594db9eab491d3f8c91e49f9d62f authored by Junio C Hamano on 29 July 2007, 00:20:52 UTC, committed by Junio C Hamano on 30 July 2007, 06:28:55 UTC
Earlier these tools refused to create a reflog entry when the
message given by the calling Porcelain had a LF in it, partially
to keep the file format integrity of reflog file, which is
one-entry-per-line.  These tools should not be dictating such a
policy.

Instead, let the codepath to write out the reflog entry worry
about the format integrity and allow messages with LF in them.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 0ec29a4
Raw File
Tip revision: 283884422f35594db9eab491d3f8c91e49f9d62f authored by Junio C Hamano on 29 July 2007, 00:20:52 UTC
symbolic-ref, update-ref: do not refuse reflog message with LF
Tip revision: 2838844
copy.c
#include "cache.h"

int copy_fd(int ifd, int ofd)
{
	while (1) {
		char buffer[8192];
		char *buf = buffer;
		ssize_t len = xread(ifd, buffer, sizeof(buffer));
		if (!len)
			break;
		if (len < 0) {
			int read_error;
			read_error = errno;
			close(ifd);
			return error("copy-fd: read returned %s",
				     strerror(read_error));
		}
		while (len) {
			int written = xwrite(ofd, buf, len);
			if (written > 0) {
				buf += written;
				len -= written;
			}
			else if (!written) {
				close(ifd);
				return error("copy-fd: write returned 0");
			} else {
				close(ifd);
				return error("copy-fd: write returned %s",
					     strerror(errno));
			}
		}
	}
	close(ifd);
	return 0;
}
back to top