Skip to main content

Browse the archive

Staging
v0.8.1
https://github.com/torvalds/linux
02 December 2023, 22:23:51 UTC
Revision 241c39b9ac4bf847013aa06cce6d4d61426a2006 authored by Trond Myklebust on 20 April 2007, 20:12:55 UTC, committed by Linus Torvalds on 21 April 2007, 05:56:30 UTC 
RPC: Fix the TCP resend semantics for NFSv4
 
Fix a regression due to the patch "NFS: disconnect before retrying NFSv4
requests over TCP"

The assumption made in xprt_transmit() that the condition
	"req->rq_bytes_sent == 0 and request is on the receive list"
should imply that we're dealing with a retransmission is false.
Firstly, it may simply happen that the socket send queue was full
at the time the request was initially sent through xprt_transmit().
Secondly, doing this for each request that was retransmitted implies
that we disconnect and reconnect for _every_ request that happened to
be retransmitted irrespective of whether or not a disconnection has
already occurred.

Fix is to move this logic into the call_status request timeout handler.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2b82f19
History
Tip revision: 241c39b9ac4bf847013aa06cce6d4d61426a2006 authored by Trond Myklebust on 20 April 2007, 20:12:55 UTC
RPC: Fix the TCP resend semantics for NFSv4
Tip revision: 241c39b
File Mode Size
Kconfig -rw-r--r-- 1.5 KB
Kconfig.iosched -rw-r--r-- 1.9 KB
Makefile -rw-r--r-- 347 bytes
as-iosched.c -rw-r--r-- 37.7 KB
blktrace.c -rw-r--r-- 12.4 KB
cfq-iosched.c -rw-r--r-- 53.1 KB
deadline-iosched.c -rw-r--r-- 11.6 KB
elevator.c -rw-r--r-- 25.1 KB
genhd.c -rw-r--r-- 17.4 KB
ioctl.c -rw-r--r-- 7.4 KB
ll_rw_blk.c -rw-r--r-- 102.4 KB
noop-iosched.c -rw-r--r-- 2.5 KB
scsi_ioctl.c -rw-r--r-- 16.3 KB
back to top