Skip to main content

Browse the archive

Staging
v0.5.0
https://github.com/git/git
23 January 2022, 05:21:09 UTC
Revision 20f1a10bfb6c31a3728a74bf1c33cb3cc5ac0c7e authored by Shawn O. Pearce on 12 July 2007, 06:31:28 UTC, committed by Shawn O. Pearce on 12 July 2007, 06:38:14 UTC 
git-gui: Work around bad interaction between Tcl and cmd.exe on ^{tree}
 
From Johannes Sixt <J.Sixt@eudaptics.com>:
> It seems that MSYS's wish does some quoting for Bourne shells,
> in particular, escape the first '{' of the "^{tree}" suffix, but
> then it uses cmd.exe to run "git rev-parse". However, cmd.exe does
> not remove the backslash, so that the resulting rev expression
> ends up in git's guts as unrecognizable garbage: rev-parse fails,
> and git-gui hickups in a way that it must be restarted.

Johannes originally submitted a patch to this section of commit.tcl
to use `git rev-parse $PARENT:`, but not all versions of Git will
accept that format.  So I'm just taking the really simple approach
here of scanning the first line of the commit to grab its tree.
About the same cost, but works everywhere.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
1 parent e87fb0f
History
Tip revision: 20f1a10bfb6c31a3728a74bf1c33cb3cc5ac0c7e authored by Shawn O. Pearce on 12 July 2007, 06:31:28 UTC
git-gui: Work around bad interaction between Tcl and cmd.exe on ^{tree}
Tip revision: 20f1a10
File Mode Size
lib
.gitignore -rw-r--r-- 62 bytes
GIT-VERSION-GEN -rwxr-xr-x 1.8 KB
Makefile -rw-r--r-- 3.7 KB
git-gui.sh -rwxr-xr-x 56.7 KB
back to top