Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision 1e2707d7e82aedf73c59772bc7aa228286323c3c authored by Miss Islington (bot) on 06 September 2019, 09:14:24 UTC, committed by Victor Stinner on 06 September 2019, 09:14:24 UTC
As noted by @eryksun in [1] and [2], using _cleanup and _active(in __del__) is not necessary on Windows, since: > Unlike Unix, a process in Windows doesn't have to be waited on by > its parent to avoid a zombie. Keeping the handle open will actually > create a zombie until the next _cleanup() call, which may be never > if Popen() isn't called again. This patch simply defines `subprocess._active` as `None`, for which we already have the proper logic in place in `subprocess.Popen.__del__`, that prevents it from trying to append the process to the `_active`. This patch also defines `subprocess._cleanup` as a noop for Windows. [1] https://bugs.python.org/issue37380GH-msg346333 [2] https://bugs.python.org/issue36067GH-msg336262 Signed-off-by: Ruslan Kuprieiev <ruslan@iterative.ai> (cherry picked from commit 042821ae3cf537e01963c9ec85d1a454d921e826) Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
1 parent 256f03b
Tip revision: 1e2707d7e82aedf73c59772bc7aa228286323c3c authored by Miss Islington (bot) on 06 September 2019, 09:14:24 UTC
bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15706)
bpo-37380: subprocess: don't use _active on win (GH-14360) (GH-15706)
Tip revision: 1e2707d
| File | Mode | Size |
|---|---|---|
| .azure-pipelines | ||
| .github | ||
| Doc | ||
| Grammar | ||
| Include | ||
| Lib | ||
| Mac | ||
| Misc | ||
| Modules | ||
| Objects | ||
| PC | ||
| PCbuild | ||
| Parser | ||
| Programs | ||
| Python | ||
| Tools | ||
| m4 | ||
| .gitattributes | -rw-r--r-- | 1.6 KB |
| .gitignore | -rw-r--r-- | 1.5 KB |
| .travis.yml | -rw-r--r-- | 6.1 KB |
| CODE_OF_CONDUCT.rst | -rw-r--r-- | 631 bytes |
| LICENSE | -rw-r--r-- | 12.5 KB |
| Makefile.pre.in | -rw-r--r-- | 62.4 KB |
| README.rst | -rw-r--r-- | 9.9 KB |
| aclocal.m4 | -rw-r--r-- | 10.7 KB |
| config.guess | -rwxr-xr-x | 43.1 KB |
| config.sub | -rwxr-xr-x | 35.4 KB |
| configure | -rwxr-xr-x | 491.8 KB |
| configure.ac | -rw-r--r-- | 163.9 KB |
| install-sh | -rwxr-xr-x | 7.0 KB |
| pyconfig.h.in | -rw-r--r-- | 42.2 KB |
| setup.py | -rw-r--r-- | 101.3 KB |
Computing file changes ...
