Skip to main content

Browse the archive

Staging
v0.8.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 190433d8150bf719fa0ba972dbacf2214942f54e authored by Miss Islington (bot) on 12 February 2020, 02:47:20 UTC, committed by GitHub on 12 February 2020, 02:47:20 UTC 
closes bpo-39605: Fix some casts to not cast away const. (GH-18453)
 

gcc -Wcast-qual turns up a number of instances of casting away constness of pointers. Some of these can be safely modified, by either:

Adding the const to the type cast, as in:

-    return _PyUnicode_FromUCS1((unsigned char*)s, size);
+    return _PyUnicode_FromUCS1((const unsigned char*)s, size);

or, Removing the cast entirely, because it's not necessary (but probably was at one time), as in:

-    PyDTrace_FUNCTION_ENTRY((char *)filename, (char *)funcname, lineno);
+    PyDTrace_FUNCTION_ENTRY(filename, funcname, lineno);

These changes will not change code, but they will make it much easier to check for errors in consts
(cherry picked from commit e6be9b59a911626d6597fe148c32f0342bd2bd24)

Co-authored-by: Andy Lester <andy@petdance.com>
1 parent 0f0d2e4
Raw File
Tip revision: 190433d8150bf719fa0ba972dbacf2214942f54e authored by Miss Islington (bot) on 12 February 2020, 02:47:20 UTC
closes bpo-39605: Fix some casts to not cast away const. (GH-18453)
Tip revision: 190433d
CODE_OF_CONDUCT.md 
# Code of Conduct

Please note that all interactions on
[Python Software Foundation](https://www.python.org/psf-landing/)-supported
infrastructure is [covered](https://www.python.org/psf/records/board/minutes/2014-01-06/#management-of-the-psfs-web-properties)
by the [PSF Code of Conduct](https://www.python.org/psf/codeofconduct/),
which includes all the infrastructure used in the development of Python itself
(e.g. mailing lists, issue trackers, GitHub, etc.).

In general, this means that everyone is expected to be **open**, **considerate**, and
**respectful** of others no matter what their position is within the project.
back to top