| 16cee38 | Junio C Hamano | 06 June 2006, 05:36:21 UTC | rev-parse: tighten constness properly. Signed-off-by: Junio C Hamano <junkio@cox.net> | 06 June 2006, 05:36:21 UTC |
| 1d84a60 | Sean | 24 May 2006, 22:04:38 UTC | A Perforce importer for git. Signed-off-by: Sean Estabrooks <seanlkml@sympatico.ca> Signed-off-by: Junio C Hamano <junkio@cox.net> | 06 June 2006, 05:17:26 UTC |
| 441c823 | Nick Hengeveld | 05 June 2006, 20:02:29 UTC | builtin-push: don't pass --thin to HTTP transport git-http-push does not currently use packs to transfer objects. Signed-off-by: Nick Hengeveld <nickh@reactrix.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 06 June 2006, 00:39:44 UTC |
| ce0bd64 | Linus Torvalds | 05 June 2006, 19:03:31 UTC | pack-objects: improve path grouping heuristics. This trivial patch not only simplifies the name hashing, it actually improves packing for both git and the kernel. The git archive pack shrinks from 6824090->6622627 bytes (a 3% improvement), and the kernel pack shrinks from 108756213 to 108219021 (a mere 0.5% improvement, but still, it's an improvement from making the hashing much simpler!) We just create a 32-bit hash, where we "age" previous characters by two bits, so the last characters in a filename count most. So when we then compare the hashes in the sort routine, filenames that end the same way sort the same way. It takes the subdirectory into account (unless the filename is > 16 characters), but files with the same name within the same subdirectory will obviously sort closer than files in different subdirectories. And, incidentally (which is why I tried the hash change in the first place, of course) builtin-rev-list.c will sort fairly close to rev-list.c. And no, it's not a "good hash" in the sense of being secure or unique, but that's not what we're looking for. The whole "hash" thing is misnamed here. It's not so much a hash as a "sorting number". [jc: rolled in simplification for computing the sorting number computation for thin pack base objects] Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 06 June 2006, 00:23:31 UTC |
| 87cefaa | Linus Torvalds | 05 June 2006, 18:44:36 UTC | rev-list: fix process_tree() conversion. The tree-walking conversion of the "process_tree()" function broke packing by using an unrelated variable from outer scope. Signed-off-by: Junio C Hamano <junkio@cox.net> | 05 June 2006, 21:54:17 UTC |
| 2befe6f | Linus Torvalds | 05 June 2006, 19:47:49 UTC | Fix typo in tutorial-2.txt This should be obvious enough. I didn't actually _test_ the tutorial, but if the old command worked, something is really wrong! Signed-off-by: Linus "Duh!" Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 05 June 2006, 20:05:49 UTC |
| 53bcf78 | Horst H. von Brand | 05 June 2006, 02:10:33 UTC | Fix Documentation/everyday.txt: Junio's workflow The workflow for Junio was badly formatted. Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl> Signed-off-by: Junio C Hamano <junkio@cox.net> | 05 June 2006, 19:27:03 UTC |
| c51901d | Horst H. von Brand | 04 June 2006, 23:53:45 UTC | Add example xinetd(8) configuration to Documentation/everyday.txt Many Linux distributions use xinetd(8), not inetd(8). Give a sample configuration file. Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl> Signed-off-by: Junio C Hamano <junkio@cox.net> | 05 June 2006, 19:26:59 UTC |
| eff97e3 | Linus Torvalds | 04 June 2006, 17:48:31 UTC | read-tree: fix eye-candy. Anton Blanchard spotted that watching checkout stage of a clone on a slow terminal takes ages because it forgot to clear the "once a second happened" flag, so instead of updates the percentage output for every file it checks out after the first second has passed. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 05 June 2006, 19:26:53 UTC |
| 4e2e564 | Aneesh Kumar K.V | 04 June 2006, 18:07:48 UTC | gitview: Add some useful keybindings. Signed-off-by: Junio C Hamano <junkio@cox.net> | 04 June 2006, 20:29:36 UTC |
| 16a4c6e | Junio C Hamano | 04 June 2006, 06:59:27 UTC | Merge branch 'lt/tree-2' * lt/tree-2: fetch.c: do not call process_tree() from process_tree(). tree_entry(): new tree-walking helper function adjust to the rebased series by Linus. Remove "tree->entries" tree-entry list from tree parser Switch "read_tree_recursive()" over to tree-walk functionality Make "tree_entry" have a SHA1 instead of a union of object pointers Add raw tree buffer info to "struct tree" Remove last vestiges of generic tree_entry_list Convert fetch.c: process_tree() to raw tree walker Convert "mark_tree_uninteresting()" to raw tree walker Remove unused "zeropad" entry from tree_list_entry fsck-objects: avoid unnecessary tree_entry_list usage Remove "tree->entries" tree-entry list from tree parser builtin-read-tree.c: avoid tree_entry_list in prime_cache_tree_rec() Switch "read_tree_recursive()" over to tree-walk functionality Make "tree_entry" have a SHA1 instead of a union of object pointers Make "struct tree" contain the pointer to the tree buffer | 04 June 2006, 06:59:27 UTC |
| f0679f4 | Junio C Hamano | 04 June 2006, 06:59:03 UTC | Merge branch 'sp/reflog' * sp/reflog: fetch.c: do not pass uninitialized lock to unlock_ref(). Test that git-branch -l works. Verify git-commit provides a reflog message. Enable ref log creation in git checkout -b. Create/delete branch ref logs. Include ref log detail in commit, reset, etc. Change order of -m option to update-ref. Correct force_write bug in refs.c Change 'master@noon' syntax to 'master@{noon}'. Log ref updates made by fetch. Force writing ref if it doesn't exist. Added logs/ directory to repository layout. General ref log reading improvements. Fix ref log parsing so it works properly. Support 'master@2 hours ago' syntax Log ref updates to logs/refs/<ref> Convert update-ref to use ref_lock API. Improve abstraction of ref lock/write. | 04 June 2006, 06:59:03 UTC |
| 731651f | Junio C Hamano | 04 June 2006, 06:58:26 UTC | Merge branch 'ff/svnimport' * ff/svnimport: git-svnimport: Improved detection of merges. | 04 June 2006, 06:58:26 UTC |
| b0d6e64 | Junio C Hamano | 03 June 2006, 08:49:31 UTC | read-tree --reset: update working tree file for conflicted paths. The earlier "git reset --hard" simplification stopped removing leftover working tree files from a failed automerge, when switching back to the HEAD version that does not have the paths. This patch, instead of removing the unmerged paths from the index, drops them down to stage#0 but marks them with mode=0 (the same "to be deleted" marker we internally use for paths deleted by the merge). one_way_merge() function and the functions it calls already know what to do with them -- if the tree we are reading has the path the working tree file is overwritten, and if it doesn't the working tree file is removed. Signed-off-by: Junio C Hamano <junkio@cox.net> | 04 June 2006, 06:57:41 UTC |
| bf41bf2 | Junio C Hamano | 04 June 2006, 06:57:15 UTC | Merge branch 'jc/fmt-patch' * jc/fmt-patch: Update documentation for git-format-patch format-patch: resurrect extra headers from config format-patch --signoff | 04 June 2006, 06:57:15 UTC |
| abda1ef | Horst H. von Brand | 03 June 2006, 20:27:26 UTC | Documentation: Spelling fixes Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl> Signed-off-by: Junio C Hamano <junkio@cox.net> | 04 June 2006, 06:54:55 UTC |
| 895f10c | Christian Couder | 03 June 2006, 16:45:43 UTC | Builtin git-rev-parse. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 04 June 2006, 06:45:30 UTC |
| ea5aeb0 | Junio C Hamano | 04 June 2006, 06:44:40 UTC | fetch: do not report "same" unless -verbose. Signed-off-by: Junio C Hamano <junkio@cox.net> | 04 June 2006, 06:44:40 UTC |
| 2f164c3 | Junio C Hamano | 03 June 2006, 01:17:35 UTC | Merge branch 'ds/doc' into jc/fmt-patch * ds/doc: Update documentation for git-format-patch sha1_file: avoid re-preparing duplicate packs handle concurrent pruning of packed objects http: prevent segfault during curl handle reuse Remove possible segfault in http-fetch. gitk: show_error fix [PATCH] gitk: start-up bugfix [PATCH] gitk: Replace "git-" commands with "git " [PATCH] gitk: Display commit messages with word wrap gitk: Fix bug where page-up/down wouldn't always work properly gitk: Fix display of "(...)" for parents/children we haven't drawn send-email: only 'require' instead of 'use' Net::SMTP Allow multiple -m options to git-commit. | 03 June 2006, 01:17:35 UTC |
| 2052d14 | Dennis Stosberg | 31 May 2006, 14:14:08 UTC | Update documentation for git-format-patch [jc: adjusted for recently resurrected features] Signed-off-by: Dennis Stosberg <dennis@stosberg.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 03 June 2006, 01:17:08 UTC |
| 6f9012b | Junio C Hamano | 02 June 2006, 22:23:47 UTC | fetch.c: do not call process_tree() from process_tree(). This function reads a freshly fetched tree object, and schedules the objects pointed by it for further fetching, so doing lookup_tree() and process_tree() recursively from there does not make much sense. We need to use process() on it to make sure we fetch it first, and leave the recursive processing to later stages. Signed-off-by: Junio C Hamano <junkio@cox.net> | 02 June 2006, 22:23:47 UTC |
| 86f7780 | Jeff King | 02 June 2006, 16:49:32 UTC | sha1_file: avoid re-preparing duplicate packs When adding packs, skip the pack if we already have it in the packed_git list. This might happen if we are re-preparing our packs because of a missing object. Signed-off-by: Junio C Hamano <junkio@cox.net> | 02 June 2006, 18:09:44 UTC |
| 637cdd9 | Jeff King | 02 June 2006, 15:32:23 UTC | handle concurrent pruning of packed objects This patch causes read_sha1_file and sha1_object_info to re-examine the list of packs if an object cannot be found. It works by re-running prepare_packed_git() after an object fails to be found. It does not attempt to clean up the old pack list. Old packs which are in use can continue to be used (until unused by lru selection). New packs are placed at the front of the list and will thus be examined before old packs. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 02 June 2006, 18:09:38 UTC |
| 3126262 | Junio C Hamano | 02 June 2006, 17:31:15 UTC | Merge branch 'nh/http' * nh/http: http: prevent segfault during curl handle reuse Remove possible segfault in http-fetch. | 02 June 2006, 17:31:15 UTC |
| 20ff068 | Johannes Schindelin | 02 June 2006, 13:21:17 UTC | format-patch: resurrect extra headers from config Once again, if you have [format] headers = "Origamization: EvilEmpire\n" format-patch will add these headers just after the "Subject:" line. Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net> | 02 June 2006, 14:30:55 UTC |
| 0825de8 | Junio C Hamano | 01 June 2006, 05:27:26 UTC | Merge git://git.kernel.org/pub/scm/gitk/gitk * git://git.kernel.org/pub/scm/gitk/gitk: gitk: show_error fix [PATCH] gitk: start-up bugfix [PATCH] gitk: Replace "git-" commands with "git " [PATCH] gitk: Display commit messages with word wrap gitk: Fix bug where page-up/down wouldn't always work properly gitk: Fix display of "(...)" for parents/children we haven't drawn | 01 June 2006, 05:27:26 UTC |
| 9094950 | Nick Hengeveld | 31 May 2006, 23:25:03 UTC | http: prevent segfault during curl handle reuse If a curl handle is configured with special options, they may reference information that is freed after the request is complete which can cause a segfault if the curl handle is reused for a different type of request. This patch resets these options to a safe state when a transfer slot is assigned to a new request. Signed-off-by: Nick Hengeveld <nickh@reactrix.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 01 June 2006, 01:24:05 UTC |
| 8784062 | Johannes Schindelin | 31 May 2006, 22:55:47 UTC | send-email: only 'require' instead of 'use' Net::SMTP This was proposed by Eric Wong and fixes the test. (Of course, git-send-email does not work, if there is no Net::SMTP here, but it will say what is wrong when you actually try to use send-email.) Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 23:17:15 UTC |
| 6891281 | Shawn Pearce | 29 May 2006, 08:45:49 UTC | Allow multiple -m options to git-commit. I find it very convenient to be able to supply multiple paragraphs of text on the command line with a single git-commit call. This change permits multiple -m/--message type options to be supplied to git-commit with each message being added as its own paragraph of text in the commit message. The -m option is still not permitted with -c/-C/-F nor are multiple occurrences of these options permitted. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 22:40:47 UTC |
| 99bd0f5 | Junio C Hamano | 31 May 2006, 22:23:44 UTC | fetch.c: do not pass uninitialized lock to unlock_ref(). Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 22:23:44 UTC |
| cf2251b | Junio C Hamano | 31 May 2006, 22:11:49 UTC | format-patch --signoff This resurrects --signoff option to format-patch. Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 22:11:49 UTC |
| 65160b8 | Florian Forster | 31 May 2006, 10:32:08 UTC | git-svnimport: Improved detection of merges. The regexes detecting merges (while still relying on the commit messages, though) have been improved to catch saner (and hopefully more) messages. The old regex was so generic that it often matched something else and missed the actual merge-message. Also, the regex given with the `-M' commandline-option is checked first: Explicitely given regexes should be considered better than the builtin ones, and should therefore be given a chance to match a message first. Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 21:22:28 UTC |
| 1361fa3 | Shawn Pearce | 29 May 2006, 07:17:18 UTC | Improved pack format documentation. While trying to implement a pack reader in Java I was mislead by some facts listed in this documentation as well as found a few details to be missing about the pack header. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 06:09:02 UTC |
| 4c068a9 | Linus Torvalds | 30 May 2006, 16:45:45 UTC | tree_entry(): new tree-walking helper function This adds a "tree_entry()" function that combines the common operation of doing a "tree_entry_extract()" + "update_tree_entry()". It also has a simplified calling convention, designed for simple loops that traverse over a whole tree: the arguments are pointers to the tree descriptor and a name_entry structure to fill in, and it returns a boolean "true" if there was an entry left to be gotten in the tree. This allows tree traversal with struct tree_desc desc; struct name_entry entry; desc.buf = tree->buffer; desc.size = tree->size; while (tree_entry(&desc, &entry) { ... use "entry.{path, sha1, mode, pathlen}" ... } which is not only shorter than writing it out in full, it's hopefully less error prone too. [ It's actually a tad faster too - we don't need to recalculate the entry pathlength in both extract and update, but need to do it only once. Also, some callers can avoid doing a "strlen()" on the result, since it's returned as part of the name_entry structure. However, by now we're talking just 1% speedup on "git-rev-list --objects --all", and we're definitely at the point where tree walking is no longer the issue any more. ] NOTE! Not everybody wants to use this new helper function, since some of the tree walkers very much on purpose do the descriptor update separately from the entry extraction. So the "extract + update" sequence still remains as the core sequence, this is just a simplified interface. We should probably add a silly two-line inline helper function for initializing the descriptor from the "struct tree" too, just to cut down on the noise from that common "desc" initializer. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 06:03:01 UTC |
| 2b60162 | Dmitry V. Levin | 29 May 2006, 00:34:34 UTC | git_exec_path, execv_git_cmd: ignore empty environment variables Ignoring empty environment variables is good common practice. Ignoring --exec-path with empty argument won't harm, too: if user means current directory, there is a "--exec-path=." Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 04:49:01 UTC |
| d685990 | Dmitry V. Levin | 30 May 2006, 14:58:52 UTC | execv_git_cmd: Fix stack buffer overflow. Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 04:47:29 UTC |
| 347f1d2 | Salikh Zakirov | 27 May 2006, 17:57:29 UTC | Fixed Cygwin CR-munging problem in mailsplit Do not open mailbox file as fopen(..., "rt") as this strips CR characters from the diff, thus breaking the patch context for changes in CRLF files. Signed-off-by: Salikh Zakirov <Salikh.Zakirov@Intel.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 31 May 2006, 04:46:03 UTC |
| 481176f | Junio C Hamano | 30 May 2006, 08:48:54 UTC | Merge branch 'ew/tests' * ew/tests: t6000lib: workaround a possible dash bug t5500-fetch-pack: remove local (bashism) usage. tests: Remove heredoc usage inside quotes t3300-funny-names: shell portability fixes | 30 May 2006, 08:48:54 UTC |
| 2186d56 | Junio C Hamano | 30 May 2006, 06:53:13 UTC | send-email: do not pass bogus address to local sendmail binary This makes t9001 test happy. Also fixes the warning on uninitialized $references variable again. Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 07:09:36 UTC |
| ce90301 | Ryan Anderson | 29 May 2006, 19:30:15 UTC | Add a basic test case for git send-email, and fix some real bugs discovered. Signed-off-by: Ryan Anderson <rda@google.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:15:37 UTC |
| 8baf06a | Ryan Anderson | 29 May 2006, 19:30:14 UTC | Fix a bug in email extraction used in git-send-email. (Also, kill off an accidentally created warning.) Signed-off-by: Ryan Anderson <rda@google.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:15:37 UTC |
| 5806324 | Ryan Anderson | 29 May 2006, 19:30:13 UTC | Add support for --bcc to git-send-email. Signed-off-by: Ryan Anderson <rda@google.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:15:37 UTC |
| 7ccf792 | Ryan Anderson | 29 May 2006, 19:30:12 UTC | git-send-email: Add References: headers to emails, in addition to In-Reply-To: Signed-off-by: Ryan Anderson <rda@google.com> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:15:36 UTC |
| 7484529 | Dennis Stosberg | 29 May 2006, 15:06:32 UTC | git-clean fails on files beginning with a dash Reproducible with: $ git init-db $ echo "some text" >-file $ git clean Removing -file rm: invalid option -- l Try `rm --help' for more information. Signed-off-by: Dennis Stosberg <dennis@stosberg.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:51 UTC |
| 037b048 | Eric Wong | 30 May 2006, 02:03:46 UTC | git-svn: remove assertion that broke with older versions of svn svn < 1.3.x would display changes to keywords lines as modified if they aren't expanded in the working copy. We already check for changes against the git tree here, so checking against the svn one is probably excessive. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:50 UTC |
| 3c4c735 | Eric Wong | 30 May 2006, 02:03:45 UTC | git-svn: t0001: workaround a heredoc bug in old versions of dash The dash installed on my Debian Sarge boxes don't seem to like <<'' as a heredoc starter. Recent versions of dash do not need this fix. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:49 UTC |
| a746f68 | J. Bruce Fields | 29 May 2006, 23:31:36 UTC | Documentation: fix a tutorial-2 typo Fix a typo. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:48 UTC |
| 62109cd | J. Bruce Fields | 29 May 2006, 23:31:34 UTC | Documentation: retitle the git-core tutorial Give the git-core tutorial a name that better reflects its intended audience. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:46 UTC |
| 3857386 | J. Bruce Fields | 29 May 2006, 23:31:33 UTC | documentation: add brief mention of cat-file to tutorial part I I'd rather avoid git cat-file so early on, but the git-cat-file -p old-commit:/path/to/file trick is too useful.... Also fix a nearby typo while we're at it. Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:45 UTC |
| 2be1bc4 | J. Bruce Fields | 29 May 2006, 23:31:32 UTC | documentation: mention gitk font adjustment in tutorial Kind of silly, but the font I get by default in gitk makes it mostly unusable for me, so this is the first thing I'd want to know about. (But maybe there's a better suggestion than just Ctrl-='ing until satisfied.) Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:44 UTC |
| 7872b18 | Horst von Brand | 29 May 2006, 21:11:28 UTC | Fix some documentation typoes Fix some typoes in Documentation/everyday.txt Signed-off-by: Horst H. von Brand <vonbrand@inf.utfsm.cl> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 06:14:40 UTC |
| 47df096 | Junio C Hamano | 30 May 2006, 05:13:09 UTC | Merge branch 'jc/lt-tree-n-cache-tree' into lt/tree-2 * jc/lt-tree-n-cache-tree: adjust to the rebased series by Linus. Remove "tree->entries" tree-entry list from tree parser Switch "read_tree_recursive()" over to tree-walk functionality Make "tree_entry" have a SHA1 instead of a union of object pointers Add raw tree buffer info to "struct tree" This results as if an "ours" merge absorbed the previous "next" branch change into the 10-patch series, but it really is a result of an honest merge. nothing to commit | 30 May 2006, 05:13:09 UTC |
| e76abd7 | Junio C Hamano | 30 May 2006, 05:00:21 UTC | adjust to the rebased series by Linus. Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 05:00:21 UTC |
| 15b5536 | Linus Torvalds | 29 May 2006, 19:21:28 UTC | Remove last vestiges of generic tree_entry_list The old tree_entry_list is dead, long live the unified single tree parser. Yes, we now still have a compatibility function to create a bogus tree_entry_list in builtin-read-tree.c, but that is now entirely local to that very messy piece of code. I'd love to clean read-tree.c up too, but I'm too scared right now, so the best I can do is to just contain the damage, and try to make sure that no new users of the tree_entry_list sprout up by not having it as an exported interface any more. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:08:37 UTC |
| 1bc995a | Linus Torvalds | 29 May 2006, 19:20:48 UTC | Convert fetch.c: process_tree() to raw tree walker This leaves only the horrid code in builtin-read-tree.c using the old interface. Some day I will gather the strength to tackle that one too. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:08:33 UTC |
| f75e53e | Linus Torvalds | 29 May 2006, 19:20:14 UTC | Convert "mark_tree_uninteresting()" to raw tree walker Not very many users to go.. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:08:29 UTC |
| 3bc1eca | Linus Torvalds | 29 May 2006, 19:19:37 UTC | Remove unused "zeropad" entry from tree_list_entry That was a hack, only needed because 'git fsck-objects' didn't look at the raw tree format. Now that fsck traverses the tree itself, we can drop it. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:08:25 UTC |
| e9a95be | Linus Torvalds | 29 May 2006, 19:19:02 UTC | fsck-objects: avoid unnecessary tree_entry_list usage Prime example of where the raw tree parser is easier for everybody. [jc: "Aieee" one-liner fix from the list applied. ] Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:08:21 UTC |
| 2d9c58c | Linus Torvalds | 29 May 2006, 19:18:33 UTC | Remove "tree->entries" tree-entry list from tree parser Instead, just use the tree buffer directly, and use the tree-walk infrastructure to walk the buffers instead of the tree-entry list. The tree-entry list is inefficient, and generates tons of small allocations for no good reason. The tree-walk infrastructure is generally no harder to use than following a linked list, and allows us to do most tree parsing in-place. Some programs still use the old tree-entry lists, and are a bit painful to convert without major surgery. For them we have a helper function that creates a temporary tree-entry list on demand. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:06:59 UTC |
| 1ccf5a3 | Linus Torvalds | 29 May 2006, 19:18:00 UTC | builtin-read-tree.c: avoid tree_entry_list in prime_cache_tree_rec() Use the raw tree walker instead. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:05:14 UTC |
| 0790a42 | Linus Torvalds | 29 May 2006, 19:17:28 UTC | Switch "read_tree_recursive()" over to tree-walk functionality Don't use the tree_entry list any more. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:05:11 UTC |
| 3a7c352 | Linus Torvalds | 29 May 2006, 19:16:46 UTC | Make "tree_entry" have a SHA1 instead of a union of object pointers This is preparatory work for further cleanups, where we try to make tree_entry look more like the more efficient tree-walk descriptor. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:05:06 UTC |
| 136f2e5 | Linus Torvalds | 29 May 2006, 19:16:12 UTC | Make "struct tree" contain the pointer to the tree buffer This allows us to avoid allocating information for names etc, because we can just use the information from the tree buffer directly. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:05:02 UTC |
| e0c97ca | Paul Mackerras | 30 May 2006, 02:01:38 UTC | Make git-diff-tree indicate when it flushes There are times when gitk needs to know that the commits it has sent to git-diff-tree --stdin did not match, and it needs to know in a timely fashion even if none of them match. At the moment, git-diff-tree outputs nothing for non-matching commits, so it is impossible for gitk to distinguish between git-diff-tree being slow and git-diff-tree saying no. This makes git-diff-tree flush its output and echo back the input line when it is not a valid-looking object name. Gitk, or other users of git-diff-tree --stdin, can use a blank line or any other "marker line" to indicate that git-diff-tree has processed all the commits on its input up to the echoed back marker line, and any commits that have not been output do not match. [jc: re-done after a couple of back-and-forth discussion on the list.] Signed-off-by: Paul Mackerras <paulus@samba.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 30 May 2006, 02:04:19 UTC |
| 22669a0 | Shawn Pearce | 29 May 2006, 08:06:48 UTC | Remove unnecessary output from t3600-rm. Moved the setup commands into test_expect_success blocks so their output is hidden unless -v is used. This makes the test suite look a little cleaner when the rm test-file setup step fails (and was expected to fail for most cases). Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 18:31:58 UTC |
| cd01d94 | Junio C Hamano | 29 May 2006, 06:00:50 UTC | Merge branch 'lt/apply' * lt/apply: apply: force matching at the beginning. Add a test-case for git-apply trying to add an ending line apply: treat EOF as proper context. | 29 May 2006, 06:00:50 UTC |
| 3f69d40 | Junio C Hamano | 29 May 2006, 05:57:47 UTC | Merge branch 'jc/cache-tree' * jc/cache-tree: (26 commits) builtin-rm: squelch compiler warnings. git-write-tree writes garbage on sparc64 Fix crash when reading the empty tree fsck-objects: do not segfault on missing tree in cache-tree cache-tree: a bit more debugging support. read-tree: invalidate cache-tree entry when a new index entry is added. Fix test-dump-cache-tree in one-tree disappeared case. fsck-objects: mark objects reachable from cache-tree cache-tree: replace a sscanf() by two strtol() calls cache-tree.c: typefix test-dump-cache-tree: validate the cached data as well. cache_tree_update: give an option to update cache-tree only. read-tree: teach 1-way merege and plain read to prime cache-tree. read-tree: teach 1 and 2 way merges about cache-tree. update-index: when --unresolve, smudge the relevant cache-tree entries. test-dump-cache-tree: report number of subtrees. cache-tree: sort the subtree entries. Teach fsck-objects about cache-tree. index: make the index file format extensible. cache-tree: protect against "git prune". ... Conflicts: Makefile, builtin.h, git.c: resolved the same way as in next. | 29 May 2006, 05:57:47 UTC |
| 0a2586c | Junio C Hamano | 29 May 2006, 05:47:53 UTC | Merge branch 'lt/tree' into jc/lt-tree-n-cache-tree * lt/tree: (98 commits) Remove "tree->entries" tree-entry list from tree parser Switch "read_tree_recursive()" over to tree-walk functionality Make "tree_entry" have a SHA1 instead of a union of object pointers Add raw tree buffer info to "struct tree" Don't use "sscanf()" for tree mode scanning git-fetch: avoid using "case ... in (arm)" mailinfo: skip bogus UNIX From line inside body mailinfo: More carefully parse header lines in read_one_header_line() Allow in body headers beyond the in body header prefix. More accurately detect header lines in read_one_header_line In handle_body only read a line if we don't already have one. Refactor commit messge handling. Move B and Q decoding into check header. Make read_one_header_line return a flag not a length. Fix memory leak in "git rev-list --objects" gitview: Move the console error messages to message dialog gitview: Add key binding for F5. Let git-clone to pass --template=dir option to git-init-db. Make cvsexportcommit create parent directories as needed. Document current cvsexportcommit limitations. ... Conflicts: Makefile, builtin.h, git.c are trivially resolved. builtin-read-tree.c needed adjustment for the tree parser change. | 29 May 2006, 05:47:53 UTC |
| 7d55561 | Junio C Hamano | 29 May 2006, 05:34:34 UTC | Merge branch 'jc/dirwalk-n-cache-tree' into jc/cache-tree * jc/dirwalk-n-cache-tree: (212 commits) builtin-rm: squelch compiler warnings. Add builtin "git rm" command Move pathspec matching from builtin-add.c into dir.c Prevent bogus paths from being added to the index. builtin-add: fix unmatched pathspec warnings. Remove old "git-add.sh" remnants builtin-add: warn on unmatched pathspecs Do "git add" as a builtin Clean up git-ls-file directory walking library interface libify git-ls-files directory traversal Add a conversion tool to migrate remote information into the config fetch, pull: ask config for remote information Fix build procedure for builtin-init-db read-tree -m -u: do not overwrite or remove untracked working tree files. apply --cached: do not check newly added file in the working tree Implement a --dry-run option to git-quiltimport Implement git-quiltimport Revert "builtin-grep: workaround for non GNU grep." builtin-grep: workaround for non GNU grep. builtin-grep: workaround for non GNU grep. ... | 29 May 2006, 05:34:34 UTC |
| 097dc3d | Linus Torvalds | 28 May 2006, 22:13:53 UTC | Remove "tree->entries" tree-entry list from tree parser This finally removes the tree-entry list from "struct tree", since most of the users can just use the tree-walk infrastructure to walk the raw tree buffers instead of the tree-entry list. The tree-entry list is inefficient, and generates tons of small allocations for no good reason. The tree-walk infrastructure is generally no harder to use than following a linked list, and allows us to do most tree parsing in-place. Some programs still use the old tree-entry lists, and are a bit painful to convert without major surgery. For them we have a helper function that creates a temporary tree-entry list on demand. We can convert those too eventually, but with this they no longer affect any users who don't need the explicit lists. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:40:18 UTC |
| 2522c13 | Linus Torvalds | 28 May 2006, 22:11:28 UTC | Switch "read_tree_recursive()" over to tree-walk functionality Don't use the tree_entry list, it really had no major reason not to just walk the raw tree instead. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:40:18 UTC |
| a755dfe | Linus Torvalds | 28 May 2006, 22:10:04 UTC | Make "tree_entry" have a SHA1 instead of a union of object pointers This is preparatory work for further cleanups, where we try to make tree_entry look more like the more efficient tree-walk descriptor. Instead of having a union of pointers to blob/tree/objects, this just makes "struct tree_entry" have the raw SHA1, and makes all the users use that instead (often that implies adding a "lookup_tree(..)" on the sha1, but sometimes the user just wanted the SHA1 in the first place, and it just avoids an unnecessary indirection). Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:40:18 UTC |
| d2eafb7 | Linus Torvalds | 28 May 2006, 22:07:07 UTC | Add raw tree buffer info to "struct tree" This allows us to avoid allocating information for names etc, because we can just use the information from the tree buffer directly. We still keep the old "tree_entry_list" in struct tree as well, so old users aren't affected, apart from the fact that the allocations are different (if you free a tree entry, you should no longer free the name allocation for it, since it's allocated as part of "tree->buffer") Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:40:18 UTC |
| 7d65848 | Linus Torvalds | 28 May 2006, 23:16:15 UTC | Don't use "sscanf()" for tree mode scanning Doing an oprofile run on the result of my git rev-list memory leak fixes and tree parsing cleanups, I was surprised by the third-highest entry being samples % image name app name symbol name 179751 2.7163 libc-2.4.so libc-2.4.so _IO_vfscanf@@GLIBC_2.4 where that 2.7% is actually more than 5% of one CPU, because this was run on a dual CPU setup with the other CPU just being idle. That seems to all be from the use of 'sscanf(tree, "%o", &mode)' for the tree buffer parsing. So do the trivial octal parsing by hand, which also gives us where the first space in the string is (and thus where the pathname starts) so we can get rid of the "strchr(tree, ' ')" call too. This brings the "git rev-list --all --objects" time down from 63 seconds to 55 seconds on the historical kernel archive for me, so it's quite noticeable - tree parsing is a lot of what we end up doing when following all the objects. [ I also see a 5% speedup on a full "git fsck-objects" on the current kernel archive, so that sscanf() really does seem to have hurt our performance by a surprising amount ] Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:39:49 UTC |
| 878ccb2 | Junio C Hamano | 29 May 2006, 02:24:28 UTC | git-fetch: avoid using "case ... in (arm)" NetBSD ash chokes on the optional open parenthesis for case arms. Inside $(command substitution), however, bash barfs without. So adjust things accordingly. Originally pointed out by Dennis Stosberg. Signed-off-by: Junio C Hamano <junkio@cox.net> | 29 May 2006, 02:24:28 UTC |
| d177e58 | Junio C Hamano | 28 May 2006, 20:39:05 UTC | Merge branch 'jc/mailinfo' * jc/mailinfo: mailinfo: skip bogus UNIX From line inside body | 28 May 2006, 20:39:05 UTC |
| 51937e5 | Junio C Hamano | 28 May 2006, 20:36:37 UTC | Merge branch 'eb/mailinfo' * eb/mailinfo: mailinfo: More carefully parse header lines in read_one_header_line() Allow in body headers beyond the in body header prefix. More accurately detect header lines in read_one_header_line In handle_body only read a line if we don't already have one. Refactor commit messge handling. Move B and Q decoding into check header. Make read_one_header_line return a flag not a length. | 28 May 2006, 20:36:37 UTC |
| ac58c7b | Dennis Stosberg | 28 May 2006, 19:08:08 UTC | git-write-tree writes garbage on sparc64 In the "next" branch, write_index_ext_header() writes garbage on a 64-bit big-endian machine; the written index file will be unreadable. I noticed this on NetBSD/sparc64. Reproducible with: $ git init-db $ :>file $ git-update-index --add file $ git-write-tree $ git-update-index error: index uses extension, which we do not understand fatal: index file corrupt Signed-off-by: Dennis Stosberg <dennis@stosberg.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 20:31:50 UTC |
| 91b452c | Linus Torvalds | 28 May 2006, 18:37:23 UTC | Fix memory leak in "git rev-list --objects" Martin Langhoff points out that "git repack -a" ends up using up a lot of memory for big archives, and that git cvsimport probably should do only incremental repacks in order to avoid having repacking flush all the caches. The big majority of the memory usage of repacking is from git rev-list tracking all objects, and this patch should go a long way in avoiding the excessive memory usage: the bulk of it was due to the object names being leaked from the tree parser. For the historic Linux kernel archive, this simple patch does: Before: /usr/bin/time git-rev-list --all --objects > /dev/null 72.45user 0.82system 1:13.55elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+125376minor)pagefaults 0swaps After: /usr/bin/time git-rev-list --all --objects > /dev/null 75.22user 0.48system 1:16.34elapsed 99%CPU (0avgtext+0avgdata 0maxresident)k 0inputs+0outputs (0major+43921minor)pagefaults 0swaps where we do end up wasting a bit of time on some extra strdup()s (which could be avoided, but that would require tracking where the pathnames came from), but we avoid a lot of memory usage. Minor page faults track maximum RSS very closely (each page fault maps in one page into memory), so the reduction from 125376 page faults to 43921 means a rough reduction of VM footprint from almost half a gigabyte to about a third of that. Those numbers were also double-checked by looking at "top" while the process was running. (Side note: at least part of the remaining VM footprint is the mapping of the 177MB pack-file, so the remaining memory use is at least partly "well behaved" from a project caching perspective). For the current git archive itself, the memory usage for a "--all --objects" rev-list invocation dropped from 7128 pages to 2318 (27MB to 9MB), so the reduction seems to hold for much smaller projects too. For regular "git-rev-list" usage (ie without the "--objects" flag) this patch has no impact. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 20:27:51 UTC |
| 7569443 | Aneesh Kumar K.V | 27 May 2006, 10:25:32 UTC | gitview: Move the console error messages to message dialog Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 17:53:08 UTC |
| 0340163 | Aneesh Kumar K.V | 27 May 2006, 10:24:14 UTC | gitview: Add key binding for F5. Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 17:52:38 UTC |
| a57c8ba | Junio C Hamano | 28 May 2006, 17:14:38 UTC | Let git-clone to pass --template=dir option to git-init-db. Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 17:14:38 UTC |
| 3f0f756 | Yann Dirson | 27 May 2006, 16:39:35 UTC | Make cvsexportcommit create parent directories as needed. This is a quick port of my initial patch for 1.0.7, that I had forgotten to post. Possibly needs some testing before applying to master. Signed-off-by: Yann Dirson <ydirson@altern.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:46:57 UTC |
| 0d71b31 | Yann Dirson | 27 May 2006, 16:39:33 UTC | Document current cvsexportcommit limitations. Since there is no bugtracker that I know of, let's just use the scripts themselves to document their limitations. Signed-off-by: Yann Dirson <ydirson@altern.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:46:50 UTC |
| ff4a9ce | Yann Dirson | 27 May 2006, 16:39:31 UTC | Do not call 'cmp' with non-existant -q flag. I cannot find when that flag was removed if it ever existed, I can find nothing about it in the ChangeLog and NEWS file of GNU diff. The current flag is -s aka --quiet aka --silent, so let's use -s, assuming it is a portable flag. Feel free to lart me with a POSIX bible if needed. Signed-off-by: Yann Dirson <ydirson@altern.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:46:07 UTC |
| 508d9e3 | Linus Torvalds | 27 May 2006, 19:24:30 UTC | Fix "--abbrev=xyz" for revision listing The revision argument parsing was happily parsing "--abbrev", but it didn't parse "--abbrev=<n>". Which was hidden by the fact that the diff options _would_ parse --abbrev=<n>, so it would actually silently parse it, it just wouldn't use it for the same things that a plain "--abbrev" was used for. Which seems a bit insane. With this patch, if you do "git log --abbrev=10" it will abbreviate the merge parent commit ID's to ten hex characters, which was probably what you expected. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:45:16 UTC |
| c928c67 | Linus Torvalds | 26 May 2006, 05:41:02 UTC | t1002: use -U0 instead of --unified=0 Using "-U0" is definitely more portable than using "--unified=0", so we should do that regardless. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:43:18 UTC |
| 63b398a | Junio C Hamano | 28 May 2006, 16:23:29 UTC | format-patch: -n and -k are mutually exclusive. Signed-off-by: Junio C Hamano <junkio@cox.net> | 28 May 2006, 16:23:29 UTC |
| b931aa5 | Petr Baudis | 26 May 2006, 16:59:17 UTC | Call builtin ls-tree in git-cat-file -p Signed-off-by: Petr Baudis <pasky@suse.cz> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 18:36:56 UTC |
| add5c8a | Junio C Hamano | 26 May 2006, 18:30:49 UTC | built-in format-patch: various fixups. - The --start-number handling introduced breakage in the normal code path. It started numbering at 0 when not --numbered, for example. - When generating one file per patch, we needlessly added an extra blank line in front for second and subsequent files. Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 18:30:49 UTC |
| e54be9e | Paul Mackerras | 26 May 2006, 12:34:30 UTC | gitk: show_error fix Bug noted by Junio C Hamano: show_error can be passed "." (root window) as its $w argument, but appending ".m" and ".ok" results in creating "..m" and "..ok" as window paths, which were invalid. This fixes it in a slightly different way from Junio's patch, though. Signed-off-by: Paul Mackerras <paulus@samba.org> | 26 May 2006, 12:34:30 UTC |
| b5e0963 | Junio C Hamano | 26 May 2006, 07:07:15 UTC | [PATCH] gitk: start-up bugfix The code to extract a message part from the error message was not passing the error message to [string range], and resulted in the show_error not getting called. Signed-off-by: Junio C Hamano <junkio@cox.net> Signed-off-by: Paul Mackerras <paulus@samba.org> | 26 May 2006, 12:25:26 UTC |
| 8974c6f | Timo Hirvonen | 24 May 2006, 07:57:40 UTC | [PATCH] gitk: Replace "git-" commands with "git " git-* commands work only if gitexecdir is in PATH. Signed-off-by: Timo Hirvonen <tihirvon@gmail.com> Signed-off-by: Paul Mackerras <paulus@samba.org> | 26 May 2006, 12:25:26 UTC |
| 88a1531 | Martin Waitz | 25 May 2006, 23:42:18 UTC | Add instructions to commit template. New users can be irritated by the git status text in their editor. Let's give them a short help. Signed-off-by: Martin Waitz <tali@admingilde.org> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 08:55:01 UTC |
| ef29c11 | Junio C Hamano | 26 May 2006, 07:46:58 UTC | mailinfo: More carefully parse header lines in read_one_header_line() We exited prematurely from header parsing loop when the header field did not have a space after the colon but we insisted on it, and we got the check wrong because we forgot that we strip the trailing whitespace before we do the check. The space after the colon is not even required by RFC2822, so stop requiring it. While we are at it, the header line is specified to be more strict than "anything with a colon in it" (there must be one or more characters before the colon, and they must not be controls, SP or non US-ASCII), so implement that check as well, lest we mistakenly think something like: Bogus not a header line: this is not. as a header line. Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 07:49:36 UTC |
| 933e4f0 | Eric Wong | 26 May 2006, 02:06:18 UTC | t6000lib: workaround a possible dash bug pdksh doesn't need this patch, of course bash works fine since that what most users use. Normally, 'var=val command' seems to work fine with dash, but perhaps there's something weird going on with "$@". dash is pretty widespread, so it'll be good to support this even though it does seem like a bug in dash. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 06:53:31 UTC |
| 1010437 | Eric Wong | 26 May 2006, 02:06:17 UTC | t5500-fetch-pack: remove local (bashism) usage. None of the variables seem to conflict, so local was unnecessary. Also replaced ${var:pos:len} with the sed equivalent. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 06:53:31 UTC |
| c7053aa | Eric Wong | 26 May 2006, 02:06:16 UTC | tests: Remove heredoc usage inside quotes The use of heredoc inside quoted strings doesn't seem to be supported by dash. pdksh seems to handle it fine, however. Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 06:53:31 UTC |
| 003d6dd | Eric Wong | 26 May 2006, 02:06:15 UTC | t3300-funny-names: shell portability fixes echo isn't remotely standardized for handling backslashes, so cat + heredoc seems better Signed-off-by: Eric Wong <normalperson@yhbt.net> Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 06:53:31 UTC |
| fa0f02d | Johannes Schindelin | 25 May 2006, 21:55:11 UTC | git-format-patch --start-number <n> Since the "a..b c..d" syntax is interpreted as "b ^a d ^c" as other range-ish commands, if you want to format a..b and then c..d and end up with files consecutively numbered, the second run needs to be able to tell the command what number to start from. This does not imply --numbered (which gives [PATCH n/m] to the subject). Signed-off-by: Junio C Hamano <junkio@cox.net> | 26 May 2006, 06:19:35 UTC |
