Skip to main content

Browse the archive

Staging
v0.5.1
https://github.com/python/cpython
09 December 2020, 11:06:31 UTC
Revision 15bc9ab301d73f20bff47a12ef05326feb40f797 authored by Guido van Rossum on 15 May 2020, 02:22:48 UTC, committed by GitHub on 15 May 2020, 02:22:48 UTC 
bpo-40612: Fix SyntaxError edge cases in traceback formatting (GH-20072)
 


This fixes both the traceback.py module and the C code for formatting syntax errors (in Python/pythonrun.c). They now both consistently do the following:

- Suppress caret if it points left of text
- Allow caret pointing just past end of line
- If caret points past end of line, clip to *just* past end of line

The syntax error formatting code in traceback.py was mostly rewritten; small, subtle changes were applied to the C code in pythonrun.c.

There's still a difference when the text contains embedded newlines. Neither handles these very well, and I don't think the case occurs in practice.

Automerge-Triggered-By: @gvanrossum
1 parent 1aa8767
History
Tip revision: 15bc9ab301d73f20bff47a12ef05326feb40f797 authored by Guido van Rossum on 15 May 2020, 02:22:48 UTC
bpo-40612: Fix SyntaxError edge cases in traceback formatting (GH-20072)
Tip revision: 15bc9ab
File Mode Size
windows-release
ci.yml -rw-r--r-- 3.3 KB
docs-steps.yml -rw-r--r-- 1.3 KB
macos-steps.yml -rw-r--r-- 768 bytes
posix-deps-apt.sh -rwxr-xr-x 590 bytes
posix-steps.yml -rw-r--r-- 2.6 KB
pr.yml -rw-r--r-- 3.2 KB
prebuild-checks.yml -rw-r--r-- 1.2 KB
windows-layout-steps.yml -rw-r--r-- 1.5 KB
windows-release.yml -rw-r--r-- 3.9 KB
windows-steps.yml -rw-r--r-- 1.5 KB
back to top