Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 14e976e00e65bf343ba0fca016c3c9132a843daf authored by Eric Appelt on 30 January 2018, 07:13:03 UTC, committed by Benjamin Peterson on 30 January 2018, 07:13:03 UTC
Fix two (in my opinion) spurious failure conditions in the lib2to3.tests.test_parser.TestParserIdempotency test_parser test. Use the same encoding found in the initial file to write a temp file for a diff. This retains the BOM if the encoding was initially utf-8-sig. If the file cannot be parsed using the normal grammar, try again with no print statement which should succeed for valid files using future print_function For case (1), the driver was correctly handling a BOM in a utf-8 file, but then the test was not writing a comparison file using 'utf-8-sig' to diff against, so the BOM got removed. I don't think that is the fault of the parser, and lib2to3 will retain the BOM. For case (2), lib2to3 pre-detects the use of from __future__ import print_function or allows the user to force this interpretation with a -p flag, and then selects a different grammar with the print statement removed. That makes the test cases unfair to this test as the driver itself doesn't know which grammar to use. As a minimal fix, the test will try using a grammar with the print statement, and if that fails fall back on a grammar without it. A more thorough handling of the idempotency test would to be to parse all files using both grammars and ignore if one of the two failed but otherwise check both. I didn't think this was necessary but can change.
1 parent ce0f33d
Tip revision: 14e976e00e65bf343ba0fca016c3c9132a843daf authored by Eric Appelt on 30 January 2018, 07:13:03 UTC
closes bpo-30117: fix lib2to3 ParserIdempotency test (GH-1242)
closes bpo-30117: fix lib2to3 ParserIdempotency test (GH-1242)
Tip revision: 14e976e
File | Mode | Size |
---|---|---|
test | ||
__init__.py | -rw-r--r-- | 162.9 KB |
__main__.py | -rw-r--r-- | 148 bytes |
colorchooser.py | -rw-r--r-- | 1.7 KB |
commondialog.py | -rw-r--r-- | 1.2 KB |
constants.py | -rw-r--r-- | 1.5 KB |
dialog.py | -rw-r--r-- | 1.5 KB |
dnd.py | -rw-r--r-- | 11.2 KB |
filedialog.py | -rw-r--r-- | 14.2 KB |
font.py | -rw-r--r-- | 6.4 KB |
messagebox.py | -rw-r--r-- | 3.6 KB |
scrolledtext.py | -rw-r--r-- | 1.8 KB |
simpledialog.py | -rw-r--r-- | 11.2 KB |
tix.py | -rw-r--r-- | 75.3 KB |
ttk.py | -rw-r--r-- | 55.7 KB |
![swh spinner](/static/img/swh-spinner.gif)
Computing file changes ...