Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC, committed by Miss Islington (bot) on 12 January 2020, 11:02:50 UTC
Motivation for this PR (comment from @vstinner in bpo issue): ``` Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2) ``` The following implementation details for the new method are TBD: 1) Public vs private 2) Inclusion in `close()` 3) Name 4) Coroutine vs subroutine method 5) *timeout* parameter If it's a private method, 3, 4, and 5 are significantly less important. I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this. https://bugs.python.org/issue38356
1 parent d7c7add
Tip revision: 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
Tip revision: 0ca7cc7
| File | Mode | Size |
|---|---|---|
| .azure-pipelines | ||
| .github | ||
| Doc | ||
| Grammar | ||
| Include | ||
| Lib | ||
| Mac | ||
| Misc | ||
| Modules | ||
| Objects | ||
| PC | ||
| PCbuild | ||
| Parser | ||
| Programs | ||
| Python | ||
| Tools | ||
| m4 | ||
| .gitattributes | -rw-r--r-- | 1.8 KB |
| .gitignore | -rw-r--r-- | 1.8 KB |
| .travis.yml | -rw-r--r-- | 8.1 KB |
| CODE_OF_CONDUCT.md | -rw-r--r-- | 630 bytes |
| LICENSE | -rw-r--r-- | 12.5 KB |
| Makefile.pre.in | -rw-r--r-- | 66.5 KB |
| README.rst | -rw-r--r-- | 9.9 KB |
| aclocal.m4 | -rw-r--r-- | 10.7 KB |
| config.guess | -rwxr-xr-x | 43.1 KB |
| config.sub | -rwxr-xr-x | 35.4 KB |
| configure | -rwxr-xr-x | 492.8 KB |
| configure.ac | -rw-r--r-- | 163.3 KB |
| install-sh | -rwxr-xr-x | 15.0 KB |
| netlify.toml | -rw-r--r-- | 82 bytes |
| pyconfig.h.in | -rw-r--r-- | 44.1 KB |
| setup.py | -rw-r--r-- | 101.7 KB |
Computing file changes ...
