Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC, committed by Miss Islington (bot) on 12 January 2020, 11:02:50 UTC
Motivation for this PR (comment from @vstinner in bpo issue): ``` Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2) ``` The following implementation details for the new method are TBD: 1) Public vs private 2) Inclusion in `close()` 3) Name 4) Coroutine vs subroutine method 5) *timeout* parameter If it's a private method, 3, 4, and 5 are significantly less important. I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this. https://bugs.python.org/issue38356
1 parent d7c7add
Tip revision: 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
Tip revision: 0ca7cc7
File | Mode | Size |
---|---|---|
pgen | ||
Python.asdl | -rw-r--r-- | 5.3 KB |
acceler.c | -rw-r--r-- | 3.3 KB |
asdl.py | -rw-r--r-- | 12.6 KB |
asdl_c.py | -rwxr-xr-x | 46.5 KB |
grammar1.c | -rw-r--r-- | 1.0 KB |
listnode.c | -rw-r--r-- | 1.6 KB |
myreadline.c | -rw-r--r-- | 10.6 KB |
node.c | -rw-r--r-- | 5.1 KB |
parser.c | -rw-r--r-- | 12.4 KB |
parser.h | -rw-r--r-- | 1.4 KB |
parsetok.c | -rw-r--r-- | 14.2 KB |
token.c | -rw-r--r-- | 4.5 KB |
tokenizer.c | -rw-r--r-- | 55.1 KB |
tokenizer.h | -rw-r--r-- | 3.7 KB |
Computing file changes ...