Staging
v0.8.1
v0.8.1
https://github.com/python/cpython
Revision 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC, committed by Miss Islington (bot) on 12 January 2020, 11:02:50 UTC
Motivation for this PR (comment from @vstinner in bpo issue): ``` Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2) ``` The following implementation details for the new method are TBD: 1) Public vs private 2) Inclusion in `close()` 3) Name 4) Coroutine vs subroutine method 5) *timeout* parameter If it's a private method, 3, 4, and 5 are significantly less important. I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this. https://bugs.python.org/issue38356
1 parent d7c7add
Tip revision: 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
Tip revision: 0ca7cc7
| File | Mode | Size |
|---|---|---|
| bdist_wininst | ||
| clinic | ||
| icons | ||
| layout | ||
| WinMain.c | -rw-r--r-- | 449 bytes |
| _msi.c | -rw-r--r-- | 32.6 KB |
| _testconsole.c | -rw-r--r-- | 3.3 KB |
| classicAppCompat.can.xml | -rw-r--r-- | 3.9 KB |
| classicAppCompat.cat | -rw-r--r-- | 10.7 KB |
| classicAppCompat.sccd | -rw-r--r-- | 18.1 KB |
| config.c | -rw-r--r-- | 5.5 KB |
| crtlicense.txt | -rw-r--r-- | 1.7 KB |
| dl_nt.c | -rw-r--r-- | 4.6 KB |
| empty.c | -rw-r--r-- | 137 bytes |
| errmap.h | -rw-r--r-- | 4.9 KB |
| errmap.mak | -rw-r--r-- | 95 bytes |
| frozen_dllmain.c | -rw-r--r-- | 3.9 KB |
| getpathp.c | -rw-r--r-- | 35.6 KB |
| invalid_parameter_handler.c | -rw-r--r-- | 549 bytes |
| launcher.c | -rw-r--r-- | 63.7 KB |
| msvcrtmodule.c | -rw-r--r-- | 15.3 KB |
| pyconfig.h | -rw-r--r-- | 19.8 KB |
| pylauncher.rc | -rw-r--r-- | 1.5 KB |
| pyshellext.cpp | -rw-r--r-- | 18.3 KB |
| pyshellext.def | -rw-r--r-- | 141 bytes |
| pyshellext.idl | -rw-r--r-- | 277 bytes |
| pyshellext.rc | -rw-r--r-- | 1.1 KB |
| pyshellext_d.def | -rw-r--r-- | 143 bytes |
| python.manifest | -rw-r--r-- | 1.3 KB |
| python3.def | -rw-r--r-- | 40.6 KB |
| python3dll.c | -rw-r--r-- | 134 bytes |
| python_exe.rc | -rw-r--r-- | 1.2 KB |
| python_nt.rc | -rw-r--r-- | 1.2 KB |
| python_uwp.cpp | -rw-r--r-- | 6.5 KB |
| python_ver_rc.h | -rw-r--r-- | 970 bytes |
| pythonw_exe.rc | -rw-r--r-- | 1.2 KB |
| readme.txt | -rw-r--r-- | 3.5 KB |
| sqlite3.rc | -rw-r--r-- | 1.3 KB |
| store_info.txt | -rw-r--r-- | 6.2 KB |
| testpy.py | -rw-r--r-- | 831 bytes |
| validate_ucrtbase.py | -rw-r--r-- | 2.7 KB |
| winreg.c | -rw-r--r-- | 63.5 KB |
| winsound.c | -rw-r--r-- | 6.5 KB |
Computing file changes ...
