Staging
v0.5.1
v0.5.1
https://github.com/python/cpython
Revision 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC, committed by Miss Islington (bot) on 12 January 2020, 11:02:50 UTC
Motivation for this PR (comment from @vstinner in bpo issue): ``` Warning seen o AMD64 Ubuntu Shared 3.x buildbot: https://buildbot.python.org/all/#/builders/141/builds/2593 test_devnull_output (test.test_a=syncio.test_subprocess.SubprocessThreadedWatcherTests) ... Warning -- threading_cleanup() failed to cleanup 1 threads (count: 1, dangling: 2) ``` The following implementation details for the new method are TBD: 1) Public vs private 2) Inclusion in `close()` 3) Name 4) Coroutine vs subroutine method 5) *timeout* parameter If it's a private method, 3, 4, and 5 are significantly less important. I started with the most minimal implementation that fixes the dangling threads without modifying the regression tests, which I think is particularly important. I typically try to avoid directly modifying existing tests as much as possible unless it's necessary to do so. However, I am open to changing any part of this. https://bugs.python.org/issue38356
1 parent d7c7add
Tip revision: 0ca7cc7fc0518c24dc9b78c38418e6064e64f148 authored by Kyle Stanley on 12 January 2020, 11:02:50 UTC
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
bpo-38356: Fix ThreadedChildWatcher thread leak in test_asyncio (GH-16552)
Tip revision: 0ca7cc7
osmodule.h
/* os module interface */
#ifndef Py_OSMODULE_H
#define Py_OSMODULE_H
#ifdef __cplusplus
extern "C" {
#endif
#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= 0x03060000
PyAPI_FUNC(PyObject *) PyOS_FSPath(PyObject *path);
#endif
#ifdef __cplusplus
}
#endif
#endif /* !Py_OSMODULE_H */
Computing file changes ...
